Itemcollector and errors

[Gino]

Tried to collect some infos today.

I works great most the time but i noticed an error.

"Wrong Size on Item_shop_struct. Got : 229, Expected: 301"
(The got value varies)
Seems to happen on merchant npc`s only.

Looks like full invent and containers are causing Problems.

Regards
Gino

Edit: NPC sold Books as well

[DeletedUser]

Ah, the item struct for books might be shorter than the standard. Nice pickup there. =)

Herm, only problem i can think of with a full inventory is insufficient buffer size, which should return some sort of zlib error (or, *gulp* crash). If i've got my head on right the max number of items on a character should be 207? (8bank + 80bank + 29inv + 80inv + 10cusorbag) That would be ~61k, buffer size in v0.4 (dont have earlier sources to check, and dont remember when i last changed it) is 75k.

Or actually, maybe the problems are related. If the item struct for books is truncated it would mess up if you had a book in your bank. Can anyone test that theory?

[Gino]

Ok little more specific then.

The error seems to occur only on merchants.
And there only if they have a Container or Book or instructions for sell.(Guess any Items that could be read applies to this)

Workaround for the moment = Buy it and then zone. :)

Note: Happend on ver 3 havent tested 4 so far.
Will add more later.

Regards
Gino

[DeletedUser]

what i was going off of was: "Edit: NPC sold Books as well".

Does this happen on NPCs that dont sell books as well?

Try running with "-o 0x0c20 -l somefilename.txt", that'll create a log of the OP_ShopItem packet. Send that to me and i can figure out what to do. =p

[DeletedUser]

T7g logged this packet for me, got it fixed. =)

Will be in PC 0.5