COMMITTED: SE_MaxHPChange
Used in the monk 2.0 epic click Peace of the Disciple and everybody's favorite MPG trial Test of Efficiency, also used in some player spells like Wake of Atrophy.
code... spell effects Code:
Index: spell_effects.cpp Code:
Index: mob.h Code:
Index: mob.cpp Code:
Index: client_mods.cpp |
Wouldn't it make more sense to calculate this as a Spell Bonus in Mob::ApplySpellBonuses()?
Mob::CalcSpellBonuses() iterates through the spell slots (including any ones that have been added by AAs) already, so it seems redundant to do it again when calling GetBuffSlotFromType() and then iterating through the spell's effects. It would also allow for stacking (if able) of the spell effects since GetBuffSlotFromType() only gets the first slot. |
Most likely there are better ways to do some of these effects as my understanding of the code isnt very comprehensive yet.
|
Updated this code like AndMetal suggested, so it uses the bonuses code and can stack, etc.
Code:
Index: bonuses.cpp |
All times are GMT -4. The time now is 12:46 AM. |
Powered by vBulletin®, Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.