Character create skill
I think at some point they changed it to where your skills capped when first creating a character, like your 1hb would be maxed when first created. I tried changing the source to not go through that routine, seems to still be doing it on player creation. Is there another place it could happen? I am not seeing a global quest causing it.
|
Is it doing it in the `class_skill` table?
|
That was my first stop. 1HB is 0 down the list except of course classes that cannot use it.
|
world/client.cpp, line 1789-1802:
https://github.com/EQEmu/Server/blob...ient.cpp#L1789 Code:
void Client::SetClassStartingSkills(PlayerProfile_Struct *pp) |
That is what is strange, in my source, which is a bit older, I remarked out the line that calls that procedure and it still happened.
Code:
// SetClassStartingSkills(&pp); |
Hmm. Maybe instead of commenting out the function call altogether, you could try changing the line that reads:
Code:
pp->skills[i] = database.GetSkillCap(pp->class_, (SkillUseTypes)i, 1); Code:
pp->skills[i] = database.GetSkillCap(pp->class_, (SkillUseTypes)i, 1) == 0 ? 0 : 1; |
Yep, still did it.
I have no idea where they are getting set at this point. Just to be positive things are compiling right I went ahead and did a make clean, checked my links (ln -s). Everything is right. |
Hmm... is it possible that Character Create actually registers a starting 1HB skill of 0, meaning it doesn't get saved into `character_skills` at all, and when the zone loads the character for the first time and doesn't find a skill value for it in the DB, it sets it to the max as a default?
|
It is possible, still diagnosing it down.
|
Looks like this is a place in the code where it might do that, but it's when a skill is trained at the Guildmaster.
zone/client_process.cpp, line 1736: https://github.com/EQEmu/Server/blob...cess.cpp#L1736 Code:
uint16 skilllevel = GetRawSkill(skill); |
I am probably out of time to look at it today, but will get back to it in the morning. It is kind of strange that did not fix it. I will do some testing Thursday.
Everything is working, this is rather minor. |
Cool. Could do a test by explicitly setting 1HB skill to, say, 3 in the character creation code after all the skill functions are called. See if it gets overridden somewhere farther down the line.
|
That was exactly my debug strategy for the morning. Right now these peeps are keeping me super busy, which is a good thing.
|
Are you sure that the client isn't overriding the server value for that level?
EDIT: Was trying to read back and see where you caught the issue first.. |
Quote:
This is a fresh character. http://legacyoffroststone.com/CharBr...php?char=Rivea |
All times are GMT -4. The time now is 03:15 PM. |
Powered by vBulletin®, Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.