Quote:
Originally Posted by joligario
When Sorvani says that it is incorrect usage - he means it is now incorrect. The plugin was changed recently, but all the quests that operated with this method have not yet been changed.
|
Actually, the return items check was always supposed to be outside of any if block by design. The items in the hash are removed by the check_handin if the logic passed to it is true.
So regardless of whether or not there is anything left in the hash, you call the return_items at the end of the EVENT_ITEM and it will appropriately return anything not used up.
The recent changes to this plugin do not affect this basic design. The recent changes were to let the plugin support the new multi-quest functionality built into the NPC's..
Edit: Post from 2009 on the subject:
http://www.eqemulator.org/forums/sho...54&postcount=3
Basically all the vanilla quests are wrong. Granted for almost all basic quest logic there con ONLY be an if and else. But a lot of the quests will eat extra items because of this.