View Single Post
  #2  
Old 01-14-2015, 10:16 PM
trevius's Avatar
trevius
Developer
 
Join Date: Aug 2006
Location: USA
Posts: 5,946
Default

Not to put down your work, but I doubt many people are going to use those plugins. The main point to plugins is to simplify something that may be complex and could be used in multiple scripts.


The majority of those plugins are 1 liners and at least some of them do not simplify anything at all. Here is an example:

Code:
sub ColorMessage {
    plugin::val('client')->Message($_[0], $_[1]);
}
Writing this:

Code:
plugin::ColorMessage(315, "Hi");
Is not any less work than writing this (in fact, it is more characters to write the plugin version):

Code:
$client->Message(315, "Hi");

Also, some will not work properly such as this one (what is this supposed to do?):
Code:
sub ClientEmote {
    $_[0]->Message(315, plugin::GetNPCName() . " $_[0]");
}
It is good to include a usage and explanation with them, which makes it easier to see how to use them and what they are actually for.

Keep in mind that all plugins get loaded into every script, so I don't recommend adding a lot of them if they are not providing something fairly useful or that will be very commonly used in lots of scripts.

It is great to share things you think will be useful with the community. Some of those plugins may come in handy, but it depends on what use they provide that isn't already available with little to no extra work. Since there aren't comments explaining them, it is hard to tell.

I hope you do not take offense to this response, as it is not meant as an attack in any way.
__________________
Trevazar/Trevius Owner of: Storm Haven
Everquest Emulator FAQ (Frequently Asked Questions) - Read It!

Last edited by trevius; 01-14-2015 at 11:34 PM..
Reply With Quote