I know this really lies with the dev team and is more of a general commit.
In concern to magic numbers / strings embedded in the code. using the example below:
Quote:
|
if (berserk && this->GetHPRatio() > 30) {
|
This 30, should be a variable in a configuration table (possible variables or some sort). This would make it easier to adjust for custom servers and if EverQuest live ever change this value, it’s not a code recompile but just a db value change.
Defiantly not a dig at sfisque at all.! (so don’t take it at that!) Its great work sfisque has helped and developed the code for this.
Just my 2cp
- froglok