Newbie armor

Sakrateri · #1 04-19-2005, 02:39 AM

nm, its no big deal

RangerDown · #2 04-19-2005, 04:09 AM

OMG that's teh uber stuff! I don't think my ranger on live is that well equipped

Cisyouc · #3 04-19-2005, 08:12 AM

Its a good quest conceptually, but there are some syntax errors with it. (Spacing, operators, etc.)

Sakrateri · #4 04-19-2005, 09:04 AM

thats odd, it works just fine the way it is on my server, I copied and pasted it straight from my .pl ??

Cisyouc · #5 04-19-2005, 12:19 PM

The main thing im concerned about is ...

Code:

if($text=~/accessories/i && $class == 'ranger')

The accepted operator for strings in perl is 'eq' not '=='.. and is considered a syntax error if interchanged because it can hinder or break performance.

The other thing is the use of &&.. its usually better to have multiple if statements..but thats just the way I would do it

If you fix your string operators, Ill sticky it

Theeper · #6 06-03-2006, 07:57 AM

Sorry to bump an old thread but ...

I don't agree with you on using multiple 'if' statements instead of stringing them together.

The original code ...

Code:

if($text=~/accessories/i && $class == 'ranger') {
.. do something ..
}

The only semi-clean way to duplicate that statement is by nesting the 'ifs' ...

Code:

if($text=~/accessories/i) {
if($class == 'ranger') {
.. do something ..
}
}

The problem is, if you want to add an 'else', or change the logic to 'or' (||)instead of 'and' (&&) ... it would be really ugly to code when the 'ifs' are nested. Granted, if you have to perform 50 operations, it would be ugly to have them all in one statement, but for small ones, I believe they should be strung together, it promotes good coding practice.

I do agree on the use of proper operators though. In this case, it works because the '==' (numerical equality operator) simply converts the text to it's ascii value and compares the two values. Since any text with the same ascii values will be the same text, the operation works. However, you should get in the practice of using operaters that match the variable type.