Perl Import_Spells.pl

Krugus · #1 06-20-2009, 01:18 AM

Ok after reading up on everything, I'm trying to import SoF spells_us.txt file Deleted the Spells_New table. Sourced in the 230_spells_table.sql then ran perl import_spells.pl and I get a grand total of 28 spells in the db and a ton of errors in the cmd screen like the following:

Quote:

Error loading "Corruption DoT Bonus 5" (15925)
DBD::mysql::db do failed: Incorrect integer value: '' for column 'aoerange' at r
ow 1 at import_spells.pl line 115, <SPELLS> line 14797.
Error loading "Corruption DoT Bonus 7" (15926)
DBD::mysql::db do failed: Incorrect integer value: '' for column 'aoerange' at r
ow 1 at import_spells.pl line 115, <SPELLS> line 14798.
Error loading "Corruption DoT Bonus 9" (15927)
DBD::mysql::db do failed: Incorrect integer value: '' for column 'aoerange' at r
ow 1 at import_spells.pl line 115, <SPELLS> line 14799.
Error loading "Place Banner" (1592

Spells Loaded: 28 of 14799
Highest ID: 15928

Using SoF client
spells_us.txt from the SoF Client
sourced in the 230_spells_table.sql
copy the import_spells.pl from a fresh download of the Trunk
perl import_spells.pl and get the above errors (more than it listed of course)

Import_spells working for SoF spells_us.txt ? or am I missing something that if it was a snake it would have bit me twice?

I even sourced in a fresh DB and copied the Structure only from it to my DB and still get the same errors as I did when I sourced in the 230_spells_table.sql.

**AndMetal** · #2 06-20-2009, 01:36 AM

Code:

Error loading "Corruption DoT Bonus 5" (15925)
DBD::mysql::db do failed: Incorrect integer value: '' for column 'aoerange' at r
ow 1 at import_spells.pl line 115, <SPELLS> line 14797.
Error loading "Corruption DoT Bonus 7" (15926)
DBD::mysql::db do failed: Incorrect integer value: '' for column 'aoerange' at r
ow 1 at import_spells.pl line 115, <SPELLS> line 14798.
Error loading "Corruption DoT Bonus 9" (15927)
DBD::mysql::db do failed: Incorrect integer value: '' for column 'aoerange' at r
ow 1 at import_spells.pl line 115, <SPELLS> line 14799.
Error loading "Place Banner" (1592
Spells Loaded: 28 of 14799
Highest ID: 15928

From /trunk/EQEmuServer/utils/sql/svn/230_spells_table.sql:

Code:

`aoerange` int(11) NOT NULL default '0'

It appears it's pulling a null value for that field in your spells file. Easiest thing to do would be to change that column in the database to allow null values.

Krugus · #3 06-20-2009, 08:39 AM

Started anew.

Pulled the spells.us.txt from a fresh install of the SoF Client

Had to modify the 230_spells_table.sql to allow the following to be NULL before it would source in via import_spells.pl would get no errors.

range
aoerange
pushback
pushup
cast_time
recovery_time
recast_time
buffduration
mana
effect_base_value2
effect_base_value5
effect_limit_value5
max1
max2
formula2
formula3
formula4
Activated
resisttype
targettype
CastingAnin
TargetAnin
field124
newicon
ResistDiff
typedescnum
effectdescnum
field158
field160
field161
EndurTimerIndex
field175
spell_category
field182
field183
field209
field210

Using Rev669 from Trunk with no modifications (I have two folders, one I modify the other is clean from trunk with no modifications).

Zone.exe crashes when I try to get past character select.

Hrrmmm back to drawing board to see what the heck is going on.

Krugus · #4 06-20-2009, 12:59 PM

Restored Database to 61209 then downloaded Trunk Rev 656. Compile it with no personal mods.

Everything works fine.

update to Trunk Rev 664.

Compile got error. Fixed client_packet.cpp and recompiled.

Start up and zone crashes over and over (bad spell data in db)

Change spdat.h to load from spells.us.txt instead of using the new database method then recompiled. (fixed the zone crashing at start up)

Works fine.

Will see if I can get import_spells to work again with the SoF spells.us.txt file. From what I am getting so far it seems its not compatible (either that or I have flying monkeys on my WinXP pro box causing havoic with my spell import :/ )

Reading the change log and doing what it tells me to do... it seems busted to me (blasted flying monkeys)

Krugus · #5 06-20-2009, 01:56 PM

What I had to do to get import_spells.pl to work on the SoF spells.us.txt file.
I changed the following fields in 230_spells_table.sql from int(11) NOT NULL to varchar(64).

range
aoerange
pushback
pushup
cast_time
recovery_time
recast_time
buffduration
mana
effect_base_value2
effect_base_value5
effect_limit_value5
max1
max2
formula2
formula3
formula4
Activated
resisttype
targettype
CastingAnin
TargetAnin
field124
newicon
ResistDiff
typedescnum
effectdescnum
field158
field160
field161
EndurTimerIndex
field175
spell_category
field182
field183
field209
field210

Sourced in all the spells (14799 of 14799).
Changed the spdat.h file to load from the DB instead of spells.us.txt file.
Removed spells.us.txt file from eqemu folder.

Started up the server.

Zone didn't crash on start up. Loaded into West Commons and casted a few spells, no crash. Not sure if everything is 100% but will keep testing......

Anyways, the 230_spells_table.sql needs to be adjusted to work with SoF spells.us.txt or it wont import via import_spells.pl

Is it just me or did anyone else have this problem? LOL

Krugus · #6 06-29-2009, 12:58 PM

Ok been doing some more research on this issue.

I'm using MySQL 5.0.77

From what I have read that in MySQL 4 and prior, if a column is set to ' ', it was just converted to a zero value but in MySQL 5 it will spit out the error "Incorrect integer value".

Further reading into this matter suggests its a sql_mode issue. It is suggested to get the old MySQL 4 behaviour back that one should execute set sql_mode = ' '; which they said an empty string means Traditional MySQL mode.

(if I'm wrong guys feel free to correct me at anytime!

)

Since the default value is empty (no modes set) and that is what set sql_mode = ' ' does.... I cleared my SQL Mode, left it empty. This setting is in your my.ini file (for those like me that didn't know :p ). There are a few different ways to access it. Directly by just finding your my.ini file and clear the SQL MODE... another way is to load up MySQL Administrator and goto Startup Variables, Click on Advanced Tab then slide about midway down in the Various box you you will find SQL Mode: You can clear it here as well.

Now after clearing this. I deleted my spells_new table. Sourced in the 230_spells_table.sql unmodified. Ran Perl import_spells.pl and it reported no errors and I had a full listing of spells (14799 of 14799).

So it was me all this time! Gah. What got me to do further research was when I tried to update my PEQ DB editor and the isbot filed spit out the error "Incorrect integer value". I looked on the boards, found no one else having this problem so off to Google I went. A few seconds later I found what my problem was. Sheesh.

So the moral of the story...... Search the Boards, Google it and do some research.

Anyways, just thought I would share

thepoetwarrior · #7 02-07-2010, 11:42 AM

Is there any quicker way to test new spells than rebooting the server after I import them?

**trevius** · #8 02-07-2010, 07:07 PM

Spells load into memory when the server starts, so you can't see any changes until a restart. Best bet is to test the changes on a test server first, so you don't affect your players with multiple restarts.

ptarp · #9 03-01-2010, 04:30 PM

I tinkered with import_spells.pl a bit.
As a test, I created a new table copy of "spells_new" table. Named it "Spells_live" and emptied it., then changed import_spells.pl with this

Code:

--- C:/test/import_spells.old.pl	Mon Mar  1 13:13:41 2010
+++ C:/test/import_spells.pl	Mon Mar  1 13:14:52 2010
@@ -9,7 +9,7 @@
 getopts('c:s:t:dh');
 my $conf = "eqemu_config.xml"; #default
 my $spellf = "spells_us.txt"; #default
-my $table = "spells_new"; #default
+my $table = "spells_live"; #default
 
 if ($opt_h) { #help (-h)
 	printf "\nUsage: import_spells.pl [-c path] [-s path] [-t table] [-d]\n";
@@ -102,6 +102,7 @@
 		}
 	} elsif (scalar(@s) > scalar(@t_col_names)) {
 		for (my $z = 1; $z <= $col_diff; $z++) {
+		  if ( length(@s) < 1 ) { @s = 0 }
 			pop(@s);
 		}
 	}

The added single line converts any null value to 0 before the string is populated.
Tested with a copy of the Spells_en.txt and spells_us.txt from my live EQ folder, and got a result of "Spells loaded: 23120 of 23120"
The resulting table 'looks' correct also, though I haven't gotten around to testing anything with it. Not sure how "correct" the code is either, since I've never really looked at perl before. Should work fine with SoF files.

ptarp · #10 03-01-2010, 08:25 PM

OK, probably nevermind on that.. Worked on my laptop, but not on my desktop on a different copy of the database. Still trying to figure it out. lol.

thepoetwarrior · #11 06-24-2010, 05:03 AM

Sorry for bringing this up again, but it would be really nice to have something like #reloadspells similar to the #reloadquest in-game command. I assume it wouldn't be too hard, or even take too much time, to write a small function in the source code to do this? Would make testing edits a lot quicker.

Hope someone notices my request =)

**cavedude** · #12 06-24-2010, 09:09 AM

Quote:

Originally Posted by thepoetwarrior

Sorry for bringing this up again, but it would be really nice to have something like #reloadspells similar to the #reloadquest in-game command. I assume it wouldn't be too hard, or even take too much time, to write a small function in the source code to do this? Would make testing edits a lot quicker.

Hope someone notices my request =)

Actually, it would be difficult and time consuming to do so, yeah. Currently, spells are loaded into shared memory which is only loaded when the server is first started. This behavior can be changed, but it would take far more time than adding a simple function. The same goes for faction, loot, and items.

thepoetwarrior · #13 06-24-2010, 09:58 PM

** sad face **