Hard-coded item/spell entries

[ChaosSlayerZ]

Greetings!

I am looking to make a list of all the possible cases of hard-coded item IDs or spell IDs that may exist in the server source.

For example: Celestial Fists (item ID 10652) are hard-coded into the source code to give them unique special effect.
This means that if I am to change/move items around, whatever is occupying the item ID 10652 will be affected.

So I would like to know if there are more items or spells IDs hard-coded like that, that I need to be aware of.

So if you aware of them, or know a quick way to search for them, please share the knowledge

[GeorgeS]

I don't have the DB in front of me, but in the spell table, is there a link to an item ID in one of the fields?

GeorgeS

[c0ncrete]

the only way i can think of checking for hard-coded item info is to find all references to GetItemIDAt(), since that's getting the itemID for a given equipment slot on the client. you'd have to manually a look at each area it was called to see if it's calculating something based on a specific item. not sure what you'd be looking for as far as spell effects off the top of my head, but you'd probably need to manually check each reference to that method as well.

[lerxst2112]

There are a lot of hardcoded spells if you consider bots as well. You'll need to look at CastSpell, SpellOnTarget, and SpellFinished calls at the very least.

[bad_captain]

I did a search for "spell_id =" and "spellid =" using GrepWin since VS search is horrible. I also opened all of the files with matches in Notepad++, so I could use "Find All in All Opened Documents" to find every occurrence. Most hard coded spell ids I found were related to AAs, but there were a few more, of course.

[lerxst2112]

Originally Posted by bad_captain

I did a search for "spell_id =" and "spellid =" using GrepWin since VS search is horrible. I also opened all of the files with matches in Notepad++, so I could use "Find All in All Opened Documents" to find every occurrence. Most hard coded spell ids I found were related to AAs, but there were a few more, of course.

I was mostly talking about all these:

zone\bot.cpp(8651):	CastSpell(SPELL_NPC_HARM_TOUCH, target->GetID());
zone\bot.cpp(8657):	CastSpell(SPELL_LAY_ON_HANDS, GetID());
zone\bot.cpp(12761):	binder->CastToNPC()->CastSpell(35, c->GetID(), 1, -1, -1);
zone\bot.cpp(12793):	runeer->CastSpell(481, c->GetID(), 1, -1, -1);
zone\bot.cpp(12797):	runeer->CastSpell(482, c->GetID(), 1, -1, -1);
zone\bot.cpp(12801):	runeer->CastSpell(483, c->GetID(), 1, -1, -1);
zone\bot.cpp(12805):	runeer->CastSpell(484, c->GetID(), 1, -1, -1);
zone\bot.cpp(12809):	runeer->CastSpell(1689, c->GetID(), 1, -1, -1);
zone\bot.cpp(12813):	runeer->CastSpell(3343, c->GetID(), 1, -1, -1);
zone\bot.cpp(13081):	g->members[i]->CastSpell(305, c->GetID(), 1, -1, -1);
zone\bot.cpp(13201):	c->GetTarget()->CastSpell(331, id);
zone\bot.cpp(13240):	g->members[i]->CastSpell(2213, t->GetID(), 1, -1, -1);
zone\bot.cpp(13245):	g->members[i]->CastSpell(3, t->GetID(), 1, -1, -1);
zone\bot.cpp(13250):	g->members[i]->CastSpell(10042, t->GetID(), 1, -1, -1);
zone\bot.cpp(13535):	evac->CastToClient()->CastSpell(2183, c->GetID(), 1, -1, -1);
zone\bot.cpp(13583):	Sower->CastSpell(278, c->GetID(), 1, -1, -1);
zone\bot.cpp(13590):	Sower->CastSpell(428, c->GetID(), 1, -1, -1);
zone\bot.cpp(13597):	Sower->CastSpell(4058, c->GetID(), 1, -1, -1);
zone\bot.cpp(13604):	Sower->CastSpell(4055, c->GetID(), 1, -1, -1);
zone\bot.cpp(13628):	Sower->CastToClient()->CastSpell(278, c->GetID(), 1, -1, -1);
zone\bot.cpp(13642):	Sower->CastToClient()->CastSpell(278, c->GetID(), 1, -1, -1);
zone\bot.cpp(13656):	Sower->CastToClient()->CastSpell(278, c->GetID(), 1, -1, -1);
zone\bot.cpp(13761):	Gater->CastSpell(550, c->GetID(), 1, -1, -1);
zone\bot.cpp(13765):	Gater->CastSpell(551, c->GetID(), 1, -1, -1);
zone\bot.cpp(13769):	Gater->CastSpell(552, c->GetID(), 1, -1, -1);
zone\bot.cpp(13773):	Gater->CastSpell(553, c->GetID(), 1, -1, -1);
zone\bot.cpp(13777):	Gater->CastSpell(554, c->GetID(), 1, -1, -1);
zone\bot.cpp(13781):	Gater->CastSpell(555, c->GetID(), 1, -1, -1);
zone\bot.cpp(13785):	Gater->CastSpell(556, c->GetID(), 1, -1, -1);
zone\bot.cpp(13789):	Gater->CastSpell(557, c->GetID(), 1, -1, -1);
zone\bot.cpp(13793):	Gater->CastSpell(558, c->GetID(), 1, -1, -1);
zone\bot.cpp(13797):	Gater->CastSpell(1398, c->GetID(), 1, -1, -1);
zone\bot.cpp(13801):	Gater->CastSpell(1434, c->GetID(), 1, -1, -1);
zone\bot.cpp(13805):	Gater->CastSpell(1438, c->GetID(), 1, -1, -1);
zone\bot.cpp(13809):	Gater->CastSpell(1440, c->GetID(), 1, -1, -1);
zone\bot.cpp(13813):	Gater->CastSpell(1517, c->GetID(), 1, -1, -1);
zone\bot.cpp(13817):	Gater->CastSpell(2020, c->GetID(), 1, -1, -1);
zone\bot.cpp(13821):	Gater->CastSpell(2419, c->GetID(), 1, -1, -1);
zone\bot.cpp(13825):	Gater->CastSpell(2424, c->GetID(), 1, -1, -1);
zone\bot.cpp(13829):	Gater->CastSpell(2429, c->GetID(), 1, -1, -1);
zone\bot.cpp(13833):	Gater->CastSpell(2432, c->GetID(), 1, -1, -1);
zone\bot.cpp(13837):	Gater->CastSpell(3184, c->GetID(), 1, -1, -1);
zone\bot.cpp(13841):	Gater->CastSpell(3792, c->GetID(), 1, -1, -1);
zone\bot.cpp(13845):	Gater->CastSpell(6184, c->GetID(), 1, -1, -1);
zone\bot.cpp(13849):	Gater->CastSpell(1737, c->GetID(), 1, -1, -1);
zone\bot.cpp(13853):	Gater->CastSpell(1736, c->GetID(), 1, -1, -1);
zone\bot.cpp(13857):	Gater->CastSpell(6179, c->GetID(), 1, -1, -1);
zone\bot.cpp(13895):	Gater->CastSpell(566, c->GetID(), 1, -1, -1);
zone\bot.cpp(13899):	Gater->CastSpell(563, c->GetID(), 1, -1, -1);
zone\bot.cpp(13903):	Gater->CastSpell(567, c->GetID(), 1, -1, -1);
zone\bot.cpp(13907):	Gater->CastSpell(561, c->GetID(), 1, -1, -1);
zone\bot.cpp(13911):	Gater->CastSpell(562, c->GetID(), 1, -1, -1);
zone\bot.cpp(13915):	Gater->CastSpell(564, c->GetID(), 1, -1, -1);
zone\bot.cpp(13919):	Gater->CastSpell(1399, c->GetID(), 1, -1, -1);
zone\bot.cpp(13923):	Gater->CastSpell(1418, c->GetID(), 1, -1, -1);
zone\bot.cpp(13927):	Gater->CastSpell(1423, c->GetID(), 1, -1, -1);
zone\bot.cpp(13931):	Gater->CastSpell(1425, c->GetID(), 1, -1, -1);
zone\bot.cpp(13935):	Gater->CastSpell(1516, c->GetID(), 1, -1, -1);
zone\bot.cpp(13939):	Gater->CastSpell(568, c->GetID(), 1, -1, -1);
zone\bot.cpp(13943):	Gater->CastSpell(2425, c->GetID(), 1, -1, -1);
zone\bot.cpp(13947):	Gater->CastSpell(2430, c->GetID(), 1, -1, -1);
zone\bot.cpp(13951):	Gater->CastSpell(2944, c->GetID(), 1, -1, -1);
zone\bot.cpp(13955):	Gater->CastSpell(3180, c->GetID(), 1, -1, -1);
zone\bot.cpp(13959):	Gater->CastSpell(6178, c->GetID(), 1, -1, -1);
zone\bot.cpp(13963):	Gater->CastSpell(2420, c->GetID(), 1, -1, -1);
zone\bot.cpp(13967):	Gater->CastSpell(1739, c->GetID(), 1, -1, -1);
zone\bot.cpp(13971):	Gater->CastSpell(666, c->GetID(), 1, -1, -1);
zone\bot.cpp(13975):	Gater->CastSpell(674, c->GetID(), 1, -1, -1);
zone\bot.cpp(13979):	Gater->CastSpell(1738, c->GetID(), 1, -1, -1);
zone\bot.cpp(13983):	Gater->CastSpell(6183, c->GetID(), 1, -1, -1);
zone\bot.cpp(13987):	Gater->CastSpell(3793, c->GetID(), 1, -1, -1);
zone\bot.cpp(14075):	Endurer->CastSpell(86, c->GetID(), 1, -1, -1);
zone\bot.cpp(14085):	Endurer->CastSpell(86, c->GetID(), 1, -1, -1);
zone\bot.cpp(14094):	Endurer->CastSpell(86, c->GetID(), 1, -1, -1);
zone\bot.cpp(14103):	Endurer->CastSpell(86, c->GetID(), 1, -1, -1);
zone\bot.cpp(14112):	Endurer->CastSpell(86, c->GetID(), 1, -1, -1);
zone\bot.cpp(14172):	Inviser->CastSpell(235, c->GetID(), 1, -1, -1);
zone\bot.cpp(14179):	Inviser->CastSpell(42, c->GetID(), 1, -1, -1);
zone\bot.cpp(14186):	Inviser->CastSpell(80, c->GetID(), 1, -1, -1);
zone\bot.cpp(14204):	Inviser->CastSpell(42, c->GetID(), 1, -1, -1);
zone\bot.cpp(14211):	Inviser->CastSpell(80, c->GetID(), 1, -1, -1);
zone\bot.cpp(14226):	Inviser->CastSpell(235, c->GetID(), 1, -1, -1);
zone\bot.cpp(14233):	Inviser->CastSpell(42, c->GetID(), 1, -1, -1);
zone\bot.cpp(14240):	Inviser->CastSpell(80, c->GetID(), 1, -1, -1);
zone\bot.cpp(14252):	Inviser->CastSpell(235, c->GetID(), 1, -1, -1);
zone\bot.cpp(14276):	Inviser->CastSpell(34, c->GetID(), 1, -1, -1);
zone\bot.cpp(14280):	Inviser->CastSpell(247, c->GetID(), 1, -1, -1);
zone\bot.cpp(14290):	Inviser->CastSpell(80, c->GetID(), 1, -1, -1);
zone\bot.cpp(14349):	Lever->CastSpell(261, c->GetID(), 1, -1, -1);
zone\bot.cpp(14361):	Lever->CastToClient()->CastSpell(261, c->GetID(), 1, -1, -1);
zone\bot.cpp(14375):	Lever->CastToClient()->CastSpell(261, c->GetID(), 1, -1, -1);
zone\bot.cpp(14389):	Lever->CastToClient()->CastSpell(261, c->GetID(), 1, -1, -1);