Wrong Section? Merchant's Items Mislabeled?

Fatboy5706 · #1 10-27-2008, 03:25 AM

Well, I play on PEQ, and I went to buy Crushed Black Marble from a merchant and it gave me a steel collar instead, 70pp waste, and then I tried to buy a Flawless Diamond and it gave me a cog... not much pp wasted on the cog. The CBM was only 31pp and it charged me 178pp for the steel collar. I do not care about the pp, but something needs to be fixed. Move this to appropriate section if need be wasn't sure where to make this. Thanks in advance.

Fatboy5706 · #2 10-27-2008, 03:36 AM

Might need to be moved to bug section, sorry for the inconvenience.

**trevius** · #3 10-27-2008, 04:26 AM

NP, I moved it to bugs. Sounds like a possible issue with the Temp merchant code. I know it was changed considerably lately. Sounds like it is worth investigating.

Fatboy5706 · #4 10-27-2008, 11:26 AM

You could keep me updated on the situation Trevius (am I allowed to capitalize that?), I know fixing things like this take time I am not rushing the resolution. Just a tidbit here and there would be helpful. Thanks in advance.

So_1337 · #5 10-27-2008, 11:48 AM

Cavedude responded over on PEQ if you'd like to follow up there. He's looking for the merchant's name that you were using.

http://www.projecteq.net/phpBB2/viewtopic.php?t=5918

**cavedude** · #6 10-27-2008, 12:04 PM

Yeah, this one is known and has been around forever. Reordering the items so they are in order by slotid corrects the problem. The items should be in order anyway, so I kinda like this bug. It lets me know when a merchant is out of order instead of going to each individually.

I am noticing a trend here, please post bugs in either PEQ or EQEmu, not both. They are going to be seen by the same people anyway so it just adds confusion.

ChaosSlayer · #7 10-27-2008, 02:21 PM

Quote:

Originally Posted by cavedude

Yeah, this one is known and has been around forever. Reordering the items so they are in order by slotid corrects the problem. The items should be in order anyway, so I kinda like this bug. It lets me know when a merchant is out of order instead of going to each individually.

I am noticing a trend here, please post bugs in either PEQ or EQEmu, not both. They are going to be seen by the same people anyway so it just adds confusion.

cavedude - could you be a little bit more specific how to "reorder" them?
or even better how to prevent this from happening?

thanks =)

**cavedude** · #8 10-27-2008, 03:09 PM

The slot column in merchantlist on a given merchant has to be in order, with no gaps. If you have a have items in slots 1, 2, 3, and 5 let's say what happens is if a player sells an item to that merchant it uses the first available slot. In this case 4. The problem arises when the next player sells an item to the merchant. It'll go in slot 5, even though an item already exists there because the server knows 4 is home to a player sold item, via merchantlist_temp.

The code should probe merchantlist before assigning a slot to merchantlist_temp to make sure it isn't already in use. That will correct the issue. However, since the slots should be in order anyway that's a moot point.

**trevius** · #9 10-27-2008, 05:36 PM

It sounds like you are right that it should be checking the merchantlist again before adding anything to merchantlist_temp. Even though it is probably best to fix every merchant so they are in order, I don't think it would be a bad idea to have it run that check of the merchantlist table again. Mainly I am thinking about servers running custom databases. Making sure all merchant tables are perfect could probably be a bit of a pain and it would be nice if people didn't have to.

Angelox · #10 10-27-2008, 05:52 PM

Agreed, that's a headache for me (renumbering everything), although I did start to do this, but quit, because I didn't see any need for it. I guess there is now.
there's got to be script that can be made to run and renumber them.

Quote:

Originally Posted by trevius

It sounds like you are right that it should be checking the merchantlist again before adding anything to merchantlist_temp. Even though it is probably best to fix every merchant so they are in order, I don't think it would be a bad idea to have it run that check of the merchantlist table again. Mainly I am thinking about servers running custom databases. Making sure all merchant tables are perfect could probably be a bit of a pain and it would be nice if people didn't have to.

**GeorgeS** · #11 10-28-2008, 10:10 AM

Adding this to the merchant editor so gaps are removed is trivial. I'll add this as an option in tonight.

GeorgeS

ChaosSlayer · #12 10-28-2008, 02:23 PM

I still don't understand why we looking into how to "reorder" out of order merchants instead of fixing the source code to prevent the problem from occruing over and over again over time.

**cavedude** · #13 10-28-2008, 03:15 PM

Because the database is wrong! That's the problem. The slots need to be in order, that's the correct way of doing things. We're just lucky the code doesn't actually use the slot to place the item, otherwise we'd see gaps on the merchants in-game.

The only reason why it is so bad is because items have been removed over time that do not belong. Now that all of the bogus items from vendors have been removed in PEQ, it has increased the gap problem considerably. Once all merchant's slots are in order starting at 1, we will no longer have a problem. The PEQ Editor, and I'm sure any other editor that works with merchantlists will automatically put any new items in order by slot. It is up to the world builder to make sure this happens.

Of course I'd like to see the code check a slot to make sure it isn't in use first before assigning it, but fixing that and then ignoring the gaps in the database is just plain lazy. If something is going to be done, it needs to be done right.

So_1337 · #14 10-28-2008, 04:05 PM

I suppose I misunderstood (and maybe ChaosSlayer did as well), as I thought you meant that these gaps could occur even if a vendor's base set of goods was perfect, just in the way that people would buy and sell items off of them.

Example: A merchant has ten items (that are correctly ordered in the database). Player A sells the merchant five items. Player B buys one of player A's items, sells six more. We now have 20 items, with one of them out of order because of the way the code works.

That may be the reason for confusion. I get it now. Thanks for explaining that it's only a database issue, and not a problem with merchants keeping items sold to them.

ChaosSlayer · #15 10-28-2008, 04:19 PM

Quote:

Originally Posted by cavedude

Because the database is wrong! That's the problem. The slots need to be in order, that's the correct way of doing things. We're just lucky the code doesn't actually use the slot to place the item, otherwise we'd see gaps on the merchants in-game.

The only reason why it is so bad is because items have been removed over time that do not belong. Now that all of the bogus items from vendors have been removed in PEQ, it has increased the gap problem considerably. Once all merchant's slots are in order starting at 1, we will no longer have a problem. The PEQ Editor, and I'm sure any other editor that works with merchantlists will automatically put any new items in order by slot. It is up to the world builder to make sure this happens.

Of course I'd like to see the code check a slot to make sure it isn't in use first before assigning it, but fixing that and then ignoring the gaps in the database is just plain lazy. If something is going to be done, it needs to be done right.

ok i guess i don't fully comprehend the entire mechnics of the system that why its somewhat confusing to me.

so merchant has item list
some items he has on his list are NOT supose to be there
those items were removed
removal created GAPS in the list

question - isn't server restart supose to reorder the list automaticly? I guess not.

In any way, from what i see the problem that merchant list in Db is been adress by some sort of internal id - (table row id#?)

and when items gets removed, the number secuence gets screwed up, right?

in this case i have stupid question: the way i understand the server boot up logic:

-server starts
-server load items and vendor info in memory
-server BUILDS vendor list based on data in DB - from my understanding- every time server starts vendor list is build from the scratch!!! this means gaps can ONLY occur if in real in ram vendor list gets altered.

In other words I don't understand how could there any sort of problem at all with thsi appraoch