default.pl

Lillu · #1 03-13-2010, 01:39 PM

We put a default.pl in the root quest directory to handle item turn in events. but strangle it seems like it does effect player's pets too, not just npcs.
putting default.pl to a specific zone folder or templates folder wont work at all.

the code is simple:

Code:

sub EVENT_ITEM {
quest::emote(" looks at you strangely.");    
plugin::return_items(\%itemcount);
}

what do we miss? any help would be appreciated.

Taurinus · #2 03-13-2010, 03:17 PM

Quote:

We put a default.pl in the root quest directory to handle item turn in events. but strangle it seems like it does effect player's pets too, not just npcs.

I find it strange that you find it strange. Pets are NPCs. Default.pl belongs in the plugins folder and only there AFAIK.

Lillu · #3 03-13-2010, 06:46 PM

fyi, default.pl doesn't belong to the plugins folder. it belongs to and works in the root quest directory.

besides I can do sub EVENT_ITEM per individual npcs, any help would be appreciated for a global solution.

Taurinus · #4 03-13-2010, 09:16 PM

oh yea, you're totally right about the placement of default.pl. I had moved it into the plugin folder on this end, to disable it (but keep it) and totally forgot where it originally went.

Could you not filter the pets out by their IDs (and by range if you wanted) if you don't want them reacting with the default behavior?

Pseudo:

Enter default behavior sub
reject pets
do your thing...

That's the only way I can think of doing it since pets are indeed npcs.

ChaosSlayerZ · #5 03-13-2010, 10:36 PM

well if someone could actually write such filtering code- would be much appreciated.

However, would nice, of our dev could include few more option in code:

-default.pl - affects npcs and pets
-default-npc.pl - affects only mobs
-default-pet.pl - affects only pets

Taurinus · #6 03-13-2010, 11:48 PM

I'm no script jockie, so keep that in mind BUT:

I did read through the wiki again real quick and came up with a working filter method for rejecting (or selecting, your choice) pets based on npc id.

Code:

sub EVENT_SAY
{
	my $mob = plugin::var('$mob');
	my $npcid = $mob->GetNPCTypeID();
	if($npcid < 1000)
{
	quest::say("I am a pet!");
}
  plugin::defaultSay();
}

With this, only pets (based on peq db distro) will respond.

**trevius** · #7 03-14-2010, 12:38 AM

If you want to have all NPCs automatically return no drop items, you could update to rev1144 or later so you can use the rule NPC:ReturnNonQuestNoDropItems that I added. It basically causes all NPCs that don't have an EVENT_ITEM to return all No Drop items handed to them. It also includes pets, but it still allows tradeable items to be handed to all NPCs and pets, so giving pets weapons still works fine. I added this to prevent players from turning in quest items to their pets or to non-quest NPCs by mistake. Seems to help a lot so far lol.

I do agree that it would be nice to have more default type script options. If you want to exclude pets from default.pl for now, the only way I know of is to make a script for every pet and put it in your templates folder. You just name them something like cleric_hammer_67_.pl or BLpet47.pl and so on. Just all of the ones in your pets table should do it. It is a bit of an annoying way to deal with it, but should work ok I think.

ChaosSlayerZ · #8 03-14-2010, 01:54 AM

ah this awesome Trev. I am pretty sure we are running revision past that one. We will check on it. Thank you for help!

Lillu · #9 03-14-2010, 06:12 AM

Thank you

**joligario** · #10 06-23-2010, 03:58 PM

Anyone been able to get zonewide default.pl to work lately? Seems broken. The same file works fine as a worldwide default.pl. Trying to use an EVENT_ITEM sub.

**joligario** · #11 06-26-2010, 11:46 AM

Ok, did a little research and testing on this and I see what is going on. When the zone is initialized, the default npc quest file is chosen because npc and zone have not yet been passed:

Code:

	string filename= "quests/", packagename = GetPkgPrefix(npcid);
	//each package name is of the form qstxxxx where xxxx = npcid (since numbers alone are not valid package names)
	questMode curmode = questDefault;
	FILE *tmpf;
//LogFile->write(EQEMuLog::Debug, "LoadScript(%d, %s):\n", npcid, zone);
	if(!npcid || !zone)
	{
//LogFile->write(EQEMuLog::Debug, "	default 1");
		filename += DEFAULT_QUEST_PREFIX;
		filename += ".pl";
		curmode = questDefault;
	}

So the system will always load quests/default.pl as the default. I can't see a way to pass the zone to attempt quests/zone/default.pl before finally settling on quests/default.pl

**Akkadius** · #12 09-21-2010, 10:57 PM

Quote:

Originally Posted by joligario

Ok, did a little research and testing on this and I see what is going on. When the zone is initialized, the default npc quest file is chosen because npc and zone have not yet been passed:

Code:

	string filename= "quests/", packagename = GetPkgPrefix(npcid);
	//each package name is of the form qstxxxx where xxxx = npcid (since numbers alone are not valid package names)
	questMode curmode = questDefault;
	FILE *tmpf;
//LogFile->write(EQEMuLog::Debug, "LoadScript(%d, %s):\n", npcid, zone);
	if(!npcid || !zone)
	{
//LogFile->write(EQEMuLog::Debug, "	default 1");
		filename += DEFAULT_QUEST_PREFIX;
		filename += ".pl";
		curmode = questDefault;
	}

So the system will always load quests/default.pl as the default. I can't see a way to pass the zone to attempt quests/zone/default.pl before finally settling on quests/default.pl

So Joligario, did you get zone default.pl to load right again?

**joligario** · #13 09-22-2010, 06:43 AM

Actually, no. I haven't had a chance to work on that much. I will look at this again soon.

**Akkadius** · #14 09-22-2010, 09:01 AM

Quote:

Originally Posted by joligario

Actually, no. I haven't had a chance to work on that much. I will look at this again soon.

Awesome, that would make zone specific events much easier to execute rather than 40 different scripts for similar functions.

**joligario** · #15 10-16-2010, 07:52 PM

Trevius worked this issue and it should be fixed as of r1705.