Npc Harm Touch/Lay On Hands

[AdrianD]

I'm curious to know how npc harm touch and lay on hands class abilities are handled. I'm prepared to add them to npc_spells_entries is they are not implemented through the aa tables.

Thanks

[AdrianD]

Figured to post my findings after a bit of assistance and some testing:

Harm touch/Lay on Hands - NPCs
+ currently, npc HT is not linked to any aa table (all aa tables removed when tested)
+ the damage from HT for npcs is not scaled in the same way it is for players
- npc HT uses spell id 929 and is triggered through a mob ability or something similar in the source
- at least up to level 55, npcs use the standard, early-level formula, spell 929
- changing this will require altering the code to disable this ability (I am currently unsure where to look for npc HT)
- one way to attain accurate results is to add to `npc_spells_entries` similar data from `aa_ranks` table, `level_req` and `spell` columns
+ npcs don't always HT if aggro'd after repop and before they are finished self buffing
+ I am unsure how LoH works but it's reasonable to assume it's similar (LoH is not as easy to test)

EDIT: This is my experience with source stable from 7/29/15

[AdrianD]

Testing of NPC LoH continued from previous:

- I am unsure how LoH works but it's reasonable to assume it's similar (LoH is not as easy to test)
	- LoH was set to hp < 20% in source which made it nearly impossible to fire in many circumstances - special_attacks.cpp(~1722)
	        - npcs choose to flee before using LoH if low %
        - changed line to 30% from 20% - works - consider 25% 
		if(GetHPRatio() < 30) {
	- hp healed is equivalent to an instant CH - at low levels, see below
		- need to alter spell data in DB or which spell is used in source
		- since I saw the spell emote in client and the aa LoH spells are not in client, it's likely spell id 87 - confirmed
		- spell 87 formula does not scale well and alternatives should be considered
                         - a quadratic makes sense in this case, if possible

Not requesting anything. Unsure if this is/was on the backburner. I'm guessing the big aa change created a bit of work.

[rhyotte]

Tagging in to keep track....