1hb skill modifier

[Foin]

I was trying to add a 1hb skill modifier to a weapon but it would not work all other skills did i asked in irc and bolly came back with this

Bolly> bonuses.cpp
<Bolly> says if (item->SkillModVlue != 0 && item->SkillModType<HIGHEST_SKILL) {
<Bolly> shoudl be != 255

[inkubus]

Hey this is gonna need a recompile to sort. I'll test it out tonight and hopefully someone with access to the build tree can fix it up later. Looks like nobody else has been using the 1hb skill on weapons

[Foin]

Great thx alot

[inkubus]

Ok i just looked at this and it seems currently it IS working fine without any changes. If you do #iteminfo on the item it shows as skill mod: 0 with xx% bonus.

The issue seems to lie in the fact that the normal item window isn't displaying 1hb skill changes so it looks like the item has no benefit. I'll look further into this for you.

[Foin]

Ahh so it does work but doesnt show Thank you i will pass that on to my community
and i will be looking forward to the fix

[gernblan]

Compiled this in too and it's definitely working.. so yeah, make it show and it's golden code

Great work, thanks!