Monk AA - Technique of Master Wu

[NatedogEZ]

I noticed you can get a chance to triple attack with this ability... but the math is incorrect.

special_attacks.cpp

				int TripleChance = 25;

				if (bDoubleSpecialAttack > 100)
					TripleChance += TripleChance*(100-bDoubleSpecialAttack)/100;

				if(TripleChance > MakeRandomInt(0,100)) {
					MonkSpecialAttack(GetTarget(), MonkSPA[MakeRandomInt(0,4)]);
				}

I'm not crazy right.. but that math makes it so that anything over 100 'bDoubleSpecialAttack' gives a LOWER chance to Triple..


200 'bDoubleSpecialAttack' ... gives a nice 0% chance to triple attack

[demonstar55]

That does appear to be a problem, and for anyone looking into it, it seems the increase to triple attack for ranks above 5 (rank 5 is 100) is (effect_value - 100) / 4. (5% additional triple attack per rank, rank 9 should come out to (9 - 5) * 5 = 20, effect value for 9 is 180, so (180 - 100) / 4 = 20, rank 10 = 25, (200 - 100) * 5 = 25, holds out for rank 18 as well, assuming it follows the 20% each rank as well)

Edit: it might just be always 1/4 the double attack chance for the AA.

Edit 2: Okay, I pushed a fix for it, just made it 1/4 the double attack chance, which seemed to back up everything I could find about it.