Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Bug Reports

Development::Bug Reports Post detailed bug reports and what you would like to see next in the emu here.

Reply
 
Thread Tools Display Modes
  #1  
Old 01-28-2020, 08:47 PM
jsr
Hill Giant
 
Join Date: Aug 2008
Location: melbourne
Posts: 171
Default Zone crash: calling Client::GetCharMaxLevelFromQGlobal()

Background:
I want the max level attainable from XP to be set according to flags. I use a global_player event_connect to set a qglobal CharMaxLevel to 50, however when I set Character:PerCharacterQglobalMaxLevel = true, logging a character in, regardless of qglobal values, causes a zone crash.


After some digging, the crash is coming from a call to QGlobalCache->GetBucket(), but this call works fine in other sections of code which seem identical. Here's a breakdown of troubleshooting I've done so far.

Troubleshooting
First I used a return value to see which line was causing the crash (should have just turned logs on, but hey)

Code:
uint32 Client::GetCharMaxLevelFromQGlobal() {
	
	return 50; <- this works

	QGlobalCache *char_c = nullptr;
	char_c = this->GetQGlobals();

	return 50; <- this works

	std::list<QGlobal> globalMap;
	uint32 ntype = 0;

	return 50; <- this works

	if(char_c) {
		QGlobalCache::Combine(globalMap, char_c->GetBucket(), ntype, this->CharacterID(), zone->GetZoneID()); <-- this is causing an error
	}

	return 50; <- this doesn't work

	...
This gave me the orange line

So I checked command_globalview, which is a similar function to see if there were differences. Syntax and parameters appear the same. I then tried using the command in game to see if it crashed the zone, and it didn't.

Code:
void command_globalview(Client *c, const Seperator *sep)
{
	NPC * npcmob = nullptr;

	if(c->GetTarget() && c->GetTarget()->IsNPC())
	{
...
}
else { QGlobalCache *char_c = nullptr; QGlobalCache *zone_c = nullptr; char_c = c->GetQGlobals(); zone_c = zone->GetQGlobals(); std::list<QGlobal> globalMap; uint32 ntype = 0; if(char_c) { QGlobalCache::Combine(globalMap, char_c->GetBucket(), ntype, c->CharacterID(), zone->GetZoneID()); <-- This works fine } ...
Then I started looking at logs for more detail and saw that the crash appears to be happening after the QGlobalCache::GetBucket() call.

Code:
[Tue Jan 28 23:25:29 2020] [Crash] x:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\list (1022): std::list<QGlobal,std::allocator<QGlobal> >::end 
[Tue Jan 28 23:25:29 2020] [Crash] x:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\list (800): std::list<QGlobal,std::allocator<QGlobal> >::list<QGlobal,std::allocator<QGlobal> > 
[Tue Jan 28 23:25:29 2020] [Crash] x:\emuserver\zone\qglobals.h (29): QGlobalCache::GetBucket 
[Tue Jan 28 23:25:29 2020] [Crash] x:\emuserver\zone\exp.cpp (1119): Client::GetCharMaxLevelFromQGlobal 
[Tue Jan 28 23:25:29 2020] [Crash] x:\emuserver\zone\client.cpp (272): Client::Client
I'm not familiar enough with c to go much further at this point, any advice would be much appreciated!
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 08:54 PM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2020, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3