Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Development

Development::Development Forum for development topics and for those interested in EQEMu development. (Not a support forum)

Reply
 
Thread Tools Display Modes
  #1  
Old 10-24-2015, 04:05 AM
Hateborne
Hill Giant
 
Join Date: May 2010
Posts: 125
Question quest::faction Not Working?

Hello ladies/gents/trolls!

I am having issues with quest::faction doing effectively nothing. From the info found at the link below, it appears to need the total value to "set" (instead of increasing). After some digging, it appears that it should actually increase it by that amount. However, testing with both the "set" value and an "increment" value did nothing to the faction value.

Faction ID: 484
Base Value (First Pass): 1200
Base Value (Second Pass): 900
Increment: 50

Tried all of the following with zero result. Tried zoning between increments, also nothing. Given the source for this option, ignoring the final 0 is effectively the same, but I've seen weird stuff here.

Code:
# first pass value of 1200 in faction_values (zoned after change, before testing)
quest::faction(484, 1250, 0); 
quest::faction(484, 1250);
# second pass value of 900 in faction_values (zoned after change, before testing)
quest::faction(484, 50, 0);
quest::faction(484, 50);
Since it's effectively calling SetFactionLevel2, there is a possibility it is busted as well. Given my ~14h working on the server, I'm a bit frazzled and a poor debugger at this point. I will try to force through a $client->SetFactionLevel2 tomorrow to see if that is busted as well. Just curious is others have had similar experiences with relatively recent source (within last 45d).


-Hate


Link: http://wiki.eqemulator.org/p?Ultimat...rence&frm=Main
Source Link #1: https://github.com/EQEmu/Server/blob...tmgr.cpp#L1236
Source Link #2: https://github.com/EQEmu/Server/blob...ient.cpp#L7710
Source Link #3: https://github.com/EQEmu/Server/blob...ient.cpp#L7769
Source Link #4: https://github.com/EQEmu/Server/blob...nedb.cpp#L3440
Reply With Quote
  #2  
Old 10-24-2015, 09:43 AM
NatedogEZ's Avatar
NatedogEZ
Developer
 
Join Date: Dec 2012
Posts: 495
Default

Do you have #gm on? Because faction hits do NOT work with #gm on.


Justed tested it to make sure.. you NEED to turn off GM flag to test the faction gains / loses. :p

Last edited by NatedogEZ; 10-24-2015 at 09:52 AM..
Reply With Quote
  #3  
Old 10-24-2015, 12:16 PM
Hateborne
Hill Giant
 
Join Date: May 2010
Posts: 125
Thumbs up

Quote:
Originally Posted by NatedogEZ View Post
Do you have #gm on? Because faction hits do NOT work with #gm on.


Justed tested it to make sure.. you NEED to turn off GM flag to test the faction gains / loses. :p

Ok, that comment I made earlier about seeing weird stuff here. That applies here. Natedog...just saying...





-Hate
Reply With Quote
Reply

Tags
faction, questmanager, questmgr, setfactionlevel2

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 03:21 AM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2020, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3