Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Development

Development::Development Forum for development topics and for those interested in EQEMu development. (Not a support forum)

Reply
 
Thread Tools Display Modes
  #16  
Old 08-25-2015, 04:42 PM
laxative
Hill Giant
 
Join Date: Aug 2008
Location: NorthEast
Posts: 115
Default

odd..

gotta go for now.. but I closed sql workbench, opened PEQ back up.

my variables are not there.. (in the database)

so that's definately off, the code compiles as the variables are defined properly in the rules, but if I'm believing this.. the database entries never made it properly....

icky.. I'll see about cleaning that up.

the zones I was testing in are using rule set 1 or 2 I **thought** i entered the PalShdBaseCritChance for rule sets 1,2, and 10.

More testing to come.

Thankyou!
Reply With Quote
  #17  
Old 08-26-2015, 08:45 AM
laxative
Hill Giant
 
Join Date: Aug 2008
Location: NorthEast
Posts: 115
Default

Rules were there, I wasnt returning enough rows in SQL workbench. Going to remove the Paladin lines completely see what happens.
Reply With Quote
  #18  
Old 08-26-2015, 08:58 AM
laxative
Hill Giant
 
Join Date: Aug 2008
Location: NorthEast
Posts: 115
Default

OK removed the code referencing the paladin, recompiled and tested. No Crits *level 8*
Leveled myself to 16, just to be sure there was no linkage to level 12.. no difference.

So a few possibilites: Innate dex crit calc not working.

Perhaps I need to modify the meleebasecritchance and/or clientbasecritchance to something like .001 instead of a zero. ?

My code didnt seem to take level into effect as I was critting at level 1.

Based on all that, it looks like the innate dex calc is off?

Is there a way to see the variable value in flight?
Reply With Quote
  #19  
Old 08-26-2015, 10:34 AM
laxative
Hill Giant
 
Join Date: Aug 2008
Location: NorthEast
Posts: 115
Default

Made a change and does appear to be working now.

I put the pal/sk check in the first if statement as follows:

Code:
		if ((GetClass() == PALADIN || GetClass() == SHADOWKNIGHT) && GetLevel() >= 15)
			critChance += RuleI(Combat, PalShdBaseCritChance);
That seemed to do the trick. The testing was much more in line with expectations. I started at level 14 and go no crits in 3 mobs over 50 swings.

Leveled up to 15, got a crit after 5 strikes, but then it went to 1 in under 20.

Not sure why the order of the statement made that much impact but it's working as I intended.

Now to improve paladin's hit chances closer to warriors.. time to sniff through more code..

-lax
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 08:33 AM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3