Host of the Elements patch

[blmille2]

This patch is to make the Host of the Elements AA look correct when cast.
No pet: Earth elemental
Otherwise: use the skin of the current pet.

Index: zone/AA.cpp
===================================================================
--- zone/AA.cpp (revision 1873)
+++ zone/AA.cpp (working copy)
@@ -583,6 +583,21 @@
                npc_type = made_npc;
        }

+       //Magician AA Host of the Elements -- Manbear (blmille2)
+       if(spell_id == 3286 || spell_id == 3287 || spell_id == 3288) {
+         made_npc = new NPCType;
+         memcpy(made_npc, npc_type, sizeof(NPCType));
+         if(GetPet()) {
+           made_npc->race = GetPet()->race;
+           made_npc->texture = GetPet()->texture;
+         } else {
+           //Defaults to Earth Elemental
+           made_npc->race = 75;
+           made_npc->texture = 0;
+         }
+         npc_type = made_npc;
+       }
+
        int summon_count = 0;
        summon_count = pet.count;

[Caryatis]

I dont remember this function from live at all, always was earth elementals as far as I remember.

Besides that though...

//Magician AA Host of the Elements -- Manbear (blmille2)

I understand you want some credit for it but signing a 10 line diff is alittle over the top lol. Personally I think its unsightly to have people signing shit left and right, but thats just me.

[steve]

Host of the Elements randomly spits out pets of all 4 types: air, water, fire, and earth. At least it does with the AA being maxed on Live. I can't remember earlier ranks.

[trevius]

Originally Posted by Caryatis

I understand you want some credit for it but signing a 10 line diff is alittle over the top lol. Personally I think its unsightly to have people signing shit left and right, but thats just me.

Not a big deal, but yeah; since we have the SVN changelog as well as the changelog.txt file, there is no need to add names to source updates. I have actually been removing names from notes like that as I see them near code I am working on. If we want to know who made what change, it is easy enough to find it on the SVN. You will still get credit in the changelog.txt as well as in the SVN rev note if the change gets added.

[bad_captain]

I only remember earth elementals when using on live in say 2004 or so. I usually used air pet, so I'm not sure that went into it. I believe I only had level one at the time though.

[blmille2]

Originally Posted by Caryatis

I dont remember this function from live at all, always was earth elementals as far as I remember.

Besides that though...


I understand you want some credit for it but signing a 10 line diff is alittle over the top lol. Personally I think its unsightly to have people signing shit left and right, but thats just me.

I was following by example.


Other than that, I got the request from one of the devs. I can look into it if the instructions weren't exactly correct.

[blmille2]

Make sure to start with a fresh SVN checkout, as the code before has been removed.

Index: zone/AA.cpp
===================================================================
--- zone/AA.cpp (revision 1873)
+++ zone/AA.cpp (working copy)
@@ -609,6 +609,23 @@
                        npc_dup = new NPCType;
                        memcpy(npc_dup, made_npc, sizeof(NPCType));
                }
+    // Host of the Elements cosmetic code
+    switch(spell_id){
+      case 3288: // Host of the Elements, Rank 3
+        npc_dup->race = 75;
+        npc_dup->texture = MakeRandomInt(0,3); // Earth, Fire, Water, Air
+        break;
+      case 3287:// Host of the Elements, Rank 2
+        npc_dup->race = 75;
+        npc_dup->texture = MakeRandomInt(0,1); // Earth, Fire
+        break;
+      case 3286:// Host of the Elements, Rank 1
+        npc_dup->race = 75;
+        npc_dup->texture = 0; // Earth
+        break;
+      default:
+        break;
+    }

                NPC* npca = new NPC(
                                (npc_dup!=NULL)?npc_dup:npc_type,       //make sure we give the NPC the correct data pointer

[blmille2]

Bumping to get this checked in.

Thanks!

[joligario]

I believe no one was checking it in because there was still open doubt as to the actual pet types vs. ranks. Did you finish the research?

[blmille2]

There was little mentioned about the actual skinning of the elements.
We know, however, that at rank 1 all of the elementals are earth.
Also, we know that at the highest rank, 3, they are all random.

I could find nothing about rank 2--and since it's cool to see the fruit of your labor manifested somehow, decided to randomly choose two skins.

At rank 3, all skins are unlocked.

Note: there is no functional difference between the different elementals--only skin.

For lack of information about rank 2, I decided to give those who spend their hard-earned AA points the satisfaction of seeing something different for a change.

[trevius]

If you can post a link to something that shows it is random at rank 3+, I don't see a problem with this submission. Looks like it goes up to rank 15 on Live now from the brief searching I did.

You mentioned you set a random chance for texture change on Rank 2 to give something for the AA purchase, but aren't the 2 extra pets that get summoned worthwhile for the purchase? From what I can see, it looks like the first 3 ranks summon 5/7/9 pets respectively. And for ranks past 3, it looks like it might just increase the duration of the pets from 30 seconds to 45, 60 and so on, but I didn't really dig too deep into it and really only the first 3 ranks are being discussed in this thread anyway.

I have no experience with this AA on Live that I can recall. Due to the conflicting information in this thread so far, I personally don't want to commit a change like this without some kind of proof. Maybe one of the other devs would know more about it, though.

My thoughts on this AA is that they would always all be earth elementals. My reason for that is purely to keep lag from this AA at a minimum. All of the other pets (with luclin models on) have effects shooting out the bottom of them, which probably cause a bit more lag. Popping out 9 fire/water/air elementals might be a noticeable hit on performance vs 9 earth elementals.

[provocating]

When I did play live, I had purchased all of the way up to level 3 Host of Elements. The only thing I got at each level was more elements, seems like it was 2 extra for each rank. But the skin never changed, it was always earth. Now they may had changed that after I quit the game, but when I played it was always the earth elemental.

[501st]

I mained a mage through lvl 80 on Live. The way I remember it was this:

There's 15 ranks at the moment.
Ranks 1-3 (When it's just adding 2 per rank)= All Earth elementals
Rank 4 (Pet Duration Increase)= All Water
Rank 5 (Pet Duration Increase)= All Fire
Rank 6 (Pet Duration Increase)= All Air
Rank 7-15 (Pet strength/level increase)= Random Elemental types

I may be a bit off but i have Rank 9 atm on Live and know for a fact as of that rank they are coming out each one as a random elemental type. I know it worked basically like that. I am a little unsure on which order the elemental types for 4/5/6 went as it's been 3 years but I'm pretty sure it was Water->Fire->Air.

So yeah as of right now the pets should be earth elementals.

-Danyelle

[provocating]

Wow, that definitely explains it then. I had no idea it went past level 3, but I quit at level 65.

[lerxst2112]

Here is the text description of the ability from a recent dbstr file from live.

616^4^This ability calls an assault of elemental minions into existence directed at a target. The minions attack the target without question until they are called back to their plane 30 seconds later. The initial rank of this ability calls five elementals. Ranks 2 and 3 add two elementals each. Ranks 4, 5, and 6 increases the time the elementals stay in this plane by 15 seconds each. Ranks 7 through 15 increase the damage dealt by the swarm.