Trading untargetable NPCs?

[NatedogEZ]

Was this live like? Currently you can trade with ANY npc no matter what.

I added a few lines into trade request to make NPCs with bodytype 11 to deny all trades.. which does work just fine.

Anyone know?

[dagulus2]

Is the spire spirit that wizards have to hand items to in their later epic untargetable?

Or the living void thing in the revamped CT?

[NatedogEZ]

The living void is target type 23 (Monster)

Not sure what the other NPC is that you are talking about.

But I can't think of a single NPC on live that required a turn in to an npc that you could not target... hmmm

Its nice to make big NPCs targettype 11 and invisible man with neat effects.. but the crappy thing is you can accidentally trade them stuff :(

Could maybe make it a rule value for no trading to Targettype 11 (No Target)

[sorvani]

post a diff, this is a good change. Type 11 should not be tradable.

[NatedogEZ]

Here is a diff of it... was a small change

--- "client_packet.cpp"	
+++ "client_packet.cpp"	
@@ -4782,6 +4782,10 @@
 	else if (tradee && (tradee->IsNPC() || tradee->IsBot())) {
 #endif
 		//npcs always accept
+		if (tradee->GetBodyType() == 11) {
+			//Do not allow trades with NO TARGET Npcs
+			return;
+		} else {
 		trade->Start(msg->to_mob_id);
 
 		EQApplicationPacket* outapp = new EQApplicationPacket(OP_TradeRequestAck, sizeof(TradeRequest_Struct));
@@ -4791,6 +4795,7 @@
 		FastQueuePacket(&outapp);
 		safe_delete(outapp);
 	}
+	}
 	return;
 }

[dagulus2]

Originally Posted by NatedogEZ

Not sure what the other NPC is that you are talking about.

I think it was called 'Spacial Distortion', its part of the 3.0 epic and I don't think its in the PEQ database. I have no idea if its targetable or not. TBH its probably best to make them untradeable and people can work around any corner cases (if any actually exist) later.