Go Back   EQEmulator Home > EQEmulator Forums > Quests > Quests::Q&A

Quests::Q&A This is the quest support section

Reply
 
Thread Tools Display Modes
  #1  
Old 04-06-2014, 05:41 PM
Esildor
Hill Giant
 
Join Date: Feb 2010
Posts: 207
Default Quest not returning items

Hi,

Not sure why this won't return items, I'm assuming because of the platinum requirement as well?

Code:
sub EVENT_ITEM {		
		if (($platinum >= 1000) && plugin::check_handin(\%itemcount, 132595 => 1))
		{
			quest::summonitem(132594);
			plugin::Whisper("Here you go $name, remember, I had nothing to do with this.");
			quest::exp(1000);
			quest::ding();
		}	
	
		else
		{
			quest::say("Sorry, $name, but I have no use for that.");
		}
	}

	plugin::return_items(\%itemcount);

}
Reply With Quote
  #2  
Old 04-06-2014, 06:12 PM
sorvani
Dragon
 
Join Date: May 2010
Posts: 966
Default

I assume that you actually mean the quest is not working and summoning the item it is supposed to?
Reply With Quote
  #3  
Old 04-06-2014, 06:31 PM
Esildor
Hill Giant
 
Join Date: Feb 2010
Posts: 207
Default

Sorry, should've clarified. I mean when you hand him the wrong item, he isn't returning it. I get the text of "blah blah don't need that" but don't actually get anything back.
Reply With Quote
  #4  
Old 04-06-2014, 06:41 PM
Township EQ
Hill Giant
 
Join Date: Sep 2013
Posts: 118
Default

put the return item in the else.. you have an extra } as well

Code:
sub EVENT_ITEM {		
	if (($platinum >= 1000) && plugin::check_handin(\%itemcount, 132595 => 1)) {
		quest::summonitem(132594);
		plugin::Whisper("Here you go $name, remember, I had nothing to do with this.");
		quest::exp(1000);
		quest::ding();
	}
	else {
		plugin::return_items(\%itemcount);
		quest::say("Sorry, $name, but I have no use for that.");
	}
}
Reply With Quote
  #5  
Old 04-06-2014, 10:07 PM
lerxst2112
Demi-God
 
Join Date: Aug 2010
Posts: 1,743
Default

As has been discussed many times before, the item return should be unconditional, not in the else.

The issue with this quest is the extra closing brace which means the return isn't even part of the event.

perl -c is your friend.
Reply With Quote
  #6  
Old 04-07-2014, 12:59 PM
sorvani
Dragon
 
Join Date: May 2010
Posts: 966
Default

Never do this.
Quote:
Originally Posted by Township EQ View Post
put the return item in the else.
Code:
sub EVENT_ITEM {		
	if (($platinum >= 1000) && plugin::check_handin(\%itemcount, 132595 => 1)) {
		quest::summonitem(132594);
		plugin::Whisper("Here you go $name, remember, I had nothing to do with this.");
		quest::exp(1000);
		quest::ding();
	}
	else {
		plugin::return_items(\%itemcount);
		quest::say("Sorry, $name, but I have no use for that.");
	}
}
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 11:31 AM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3