EQEmulator Forums - Damage Bonus Functions

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)

- Development::Development (https://www.eqemulator.org/forums/forumdisplay.php?f=590)

- - Damage Bonus Functions (https://www.eqemulator.org/forums/showthread.php?t=26262)

i created a new level 1 paladin and started leveling today, and i'm hitting things for 250+. Did i merge something wrong or can someone else confirm this?

after more testing my paladin using a 1hs damage 4 delay 29 hit for 250+ until level 23 then started hitting for 10-20 (seems more normal) 2hs damage seemed fine tho.

i just readded the level check (think you forgot to put it back in after some editing) and eveything works fine again

Code:

if( GetLevel() < 28 || !IsWarriorClass() )

        {

                // Either the PC's level is less than 28 (damage bonuses do not begin to apply until level 28),

                // or the PC is not a melee class (only melee classes receive a damage bonus).



                return 0;

        }

Quote:

Originally Posted by Flare83 (Post 157078)

i just readded the level check (think you forgot to put it back in after some editing) and eveything works fine again

Hi, Flare!

Please check step #4 in the instructions on how to build these new Damage Bonus changes. The level check is still in there; I just moved it outside of the Damage Bonus function itself (after all, why bother with function calling overhead if you aren't high enough level to receive a damage bonus?)

Here are the relevant lines:

Code:

if( Hand == 13 && GetLevel() >= 28 && IsWarriorClass() )

{

        // Damage bonuses apply only to hits from the main hand (Hand == 13) by characters level 28 and above

        // who belong to a melee class. If we're here, then all of these conditions apply.



        int8 ucDamageBonus = GetWeaponDamageBonus( weapon ? weapon->GetItem() : (const Item_Struct*) NULL );



        min_hit += (int) ucDamageBonus;

        max_hit += (int) ucDamageBonus;

}

Sounds like perhaps you overlooked this when building the changes. No worries!

Take care!