Most likely, this line:

https://github.com/EQEmu/Server/blob...rof2.cpp#L2340

Need to be changed to this:

Should be pretty easy to test and get that implemented.

Nope, didn't work :(

Oops, my bad, try here instead:

https://github.com/EQEmu/Server/blob...rof2.cpp#L2496

Compared to UF, this should almost certainly work. If it works, feel free to commit it and save me the time :)

Works, commited.

I cannot test this right now, but I believe this may resolve some of the discipline update and combat skills window issues on RoF2:


Change this line:
https://github.com/EQEmu/Server/blob...structs.h#L117

To this:
static const uint32 MAX_PP_DISCIPLINES = 300; // was 200

That is just based off of a Live PP, which has 300 Disciplines. It could be that sending only 200 is causing the client to reference 400 bytes of random memory when doing discipline updates, which might explain why the combat skills window displays a bunch of unknown spells with level 255 until you zone (and the issue gets corrected by the Player Profile).

I will test this later and see what it does. It could be that they increased it from 200 to 300 sometime after RoF2 and this may not work. Might be nice to add a #untraindiscs command as well since the only way to untrain them currently is using quest commands in scripts.

It would also probably be good to get MAX_PP_DISCIPLINES moved into eqdictionary at some point. And, switching to use the RoF2 MAX_PP_DISCIPLINES for our internal rep at some point would be good too.

Tested and commited.

Sweet, thanks! So, I take it that the test prevented the extra unknown 255 spells from showing up in the combat abilities window after training discs on a character that didn't have any before?

Did it also allow for updating the skills list without having to zone first?

If yes to both, we can probably stick the same change on RoF1 if anyone cares to do so. Or, just have Uleat add them to eqdictionary and update the values to the new one :)

Yep. And some more characters.

Edit: Fixed. Weird issue.

Something I've been noticing while working on the new inventory system and logging in/out frequently.

The character I'm testing with is a monk and mend is often on cooldown when I initially zone into a zone and with seemingly random times (from 1-5 minutes).

Incidentally one time I went and used it and then next time I zoned in it was off cooldown instead!

Its on cool down on live as well on log in

Seems odd since it's never on CD the same amount and sometimes not on CD.

I don't know offhand if we track it anywhere yet or why it would be randomly refreshed after logging in, but here is a note which I think is from Derision back from RoF1 (which I just copied to RoF2):

https://github.com/EQEmu/Server/blob...rof2.cpp#L2344

If we start passing a timestamp there, we can probably prevent the random refresh timers client-side for Mend. Since it currently sends 0, I am not sure why it is randomly working. Unless, maybe that is incorrectly identified in the PP and it is actually picking up a value from a mis-identified field somewhere.

One thing I've noticed on PEQ is the mushrooms in the tutorial are floating in the air with ROF2, but are on the ground using the UF client. Not sure if other ground spawns are affected. Mobs are ok.

I think they removed the clients code for stuff to find the ground, probably for player housing so the players could place stuff floating, as a side effect, anything on eqemu that is off, will be floating.