Yep, lootdrop.add.tmpl.php creates those variables and sends them to loot.php for use in assign_lootdrop().
|
Well I feel stupid to an extent. When I woke up today I deleted every file with a change date that did not match up with the SVN, then reapplied my custom changes for misc stuff like website integration and everything works like it should.
So at some point in time I changed one of the pages and was not careful with copying from SVN to my web folder and that would explain when I was adding loot drops mindrop,droplimit,multiplier,probability were zero and also I just checked adding items and noticed that I was not careful in the past because the current revision from svn when I add items now I do have the option to change percent. So thanks cavedude for suffering my posts. It was still nice to take a few min and look at how everything is setup and play with it. I was able to make some personalized changes to aspects of the tool yesterday and get an idea for how it should look based on the current templates. Anyways, thanks as always to you and everyone else from peq that keep this tool up to date. |
Reference: http://www.peqtgc.com/phpBB3/viewtopic.php?f=29&t=14068
I think this is a good idea and decided to go mucking around inside the editor... again. This time I am going to include some pictures of the table I tested against. http://imageshack.us/a/img802/960/zlzo.png Then what the new option you clicked on brings up. I used one of the 13x13 icons included with the editor for this test. http://imageshack.us/a/img5/4364/m2ue.png And what the result ended up being after choosing the copy option. http://imageshack.us/a/img4/2701/mrqo.png You can either choose move (move and delete from old) or copy (move and retain original). Here is a patch and I'm pretty sure I did not fubar up this time but its probably not the best way to handle it. Either way you cut it, it does work and can be made pretty as needed. IE I created a new template page but was that really the best method? Code:
Index: lib/loot.php |
Thanks for that! I'll be merging it into the next commit, it's very well done. The only thing I changed was I made copy the default option.
|
Also, I wanted to say keep mucking! Once you get a solid grasp of the editor, I'll have no problem giving you SVN access, so you can commit your changes directly.
|
I enjoy tinkering with the tools the eqemu community uses and produces.
The peq editor has been a favorite of mine for some time since I sometimes forget to double check sql syntax and then I end up borking entire tables. Just ask Natedog he was on vent with me the other day when I had to drop altadv_vars because I changed in range using <= and <= ... silly me. GUI interfaces help reduce the mistakes I make :) I would have posted this on the PEQ boards but for some reason I just never made a forum account there, no idea why because I monitor the forums for all gold/green and high pop white server looking for reasons to tinker with things. I can't think of anything else the editor could use that would not step on other tools that are already well made or bloat it in size but I'll continue poking it with a spork and post .patch files for stuff to be considered. |
Figured I would attempt to break guilds tab.
Had to tweak it a little to fit the new button and I think its kind of ugly but not sure if its really something useful so making it pretty can come later. http://img580.imageshack.us/img580/1390/l3jx.png Grabs the next ID for you, just need to input the guild name and the name of the character that is to be the leader. Not sure if guild names can contain characters that require escaping for sql so did not attempt to check for that in the query. So "Dan's party guild" would probably fail to insert. Code:
Index: css/peq.css |
Issues inside editor
I have the editor running and connecting to my database. I can actually make changes. But I get tons of errors on the opening page and when creating new items. (This is so far that I am aware of)
I am using the latest install of XAMPP 1.8.2.1 The first is: Notice: Use of undefined constant c71 - assumed 'c71' in C:\xampp\htdocs\peq\lib\data.php on line 2601 *This error above is actually the last in 100 plus errors that are before the actual interface. I began manually formatting all entries in data.php that have a letter before the number with single quotes ('c71'). This seemed to fix this issue. But I am not sure what impact this has. The second is: Notice: Undefined variable: *This occurs when creating a new item. Almost all selectable boxes begin with this error. I also noticed when I create NPCs that very few are available and pull up only the human model even when say Bristlebane is selected. I am not a programer, but I enjoy EQ and my step son and I love playing on our own home server. I am attempting to make it more fun for him by slightly customizing our server. Volkmeer |
Quote:
Not sure off the top of my head why you are seeing the error. I'll check this again later today when I have more time, though probably a more knowledgeable person will have responded by then, or at least I hope so. |
Thanks for reply. I really want to get this working. My data.php from the current download has 2606 lines total.
By adding the single quotes i have fixed a number of issues. But I get undefined variables in the interface: Notice: Undefined variable: table_string in C:\xampp\htdocs\peq\lib\npc.php on line 2035 Notice: Undefined variable: update_string in C:\xampp\htdocs\peq\lib\npc.php on line 2047 and Notice: Undefined variable: version in C:\xampp\htdocs\peq\lib\headbars.php on line 347 Notice: Undefined variable: version in C:\xampp\htdocs\peq\lib\headbars.php on line 352 and (Item Creation seems really broken as all fields have the variable error) Notice: Undefined variable: filename in C:\xampp\htdocs\peq\templates\items\items.add.tmpl .php on line 51 Notice: Undefined variable: filename in C:\xampp\htdocs\peq\templates\items\items.add.tmpl .php on line 54 It looks like the 'php' code is calling a field in the database and associating it with a variable. But, what happens is it is not keeping that association when it runs a greater or less than query against it. Hope that makes sense. It looks like if 1=apple, then apple=grape, grape > 3 goto 'tree', if grape < 3 goto bush. But grape doesnt seem to '=' 1 anymore. Anyway somethings do work still. If you have a different version of the tool I would definitely try it! If you tell me how i could upload the tool contents I have I would do that as well. Volkmeer |
This problem was handled by Joligario farther up in this thread:
Quote:
Also, none of your line numbers line up with the current release, so grab the editor from here (updated daily): http://www.peqtgc.com/releases/ |
Ok I made the php.ini change and i downloaded the new editor. I actually get more variable errors now.
|
Notices are not errors. Think of them as just warnings.
Since you are using 1.8.2, that has newer PHP. I recommend using this to turn off all the strict/warnings. Code:
error_reporting = E_ALL & ~E_NOTICE & ~E_STRICT & ~E_DEPRECATED & ~E_WARNING |
Report back if joligario's suggestion does not work out. As I said earlier there are a bunch of people that will assist in figuring it out with you.
|
Made the above changes but still get the variable error. Seems everything is working just errors everywhere.
|
Not descriptive enough for anyone to help you.
|
Can you print screen, crop it and post that so we can see what is going on.
|
I noticed there were few missing spell effects in the Spell editor when I grabbed the newest PEQ editor from the daily dump.
I decided to update the ones that were OLD "unknowns" that are now known to the correct effect name and added all the ones that were missing. Placed "NI" at the from the effect if it wasn't implement as of 10 /3 /2013 Code:
--- "lib\spellenums.php" |
Found a few missing fields for item edit / add.
Allow for augtype up to 20 http://i.imgur.com/vLo0ITP.png Code:
--- "templates\iframes\js.tmpl.php" Code:
--- "templates\items\items.add.tmpl.php" Code:
--- "templates\items\items.edit.tmpl.php" Code:
--- "lib\items.php" Thank you for this wonderful tool :) Created a random item with it :) http://i.imgur.com/0jUFW01.png |
Thank you for the contribution. I'll get this in tonight.
|
A few more edits / tweaks that might seem useful / helpful for people.
Augtypes up to 30 Add "_copy" to items and spells that are copied using the copy button. (I cant count the number of times I edited the same item because I forgot to copy -- this helps remind you it was copied) js.tmpl.php Code:
--- "templates\iframes\js.tmpl.php" Add "_copy" to spell name that is copied! Code:
--- "lib\spells.php" Add the augtypes to the add and edit templates Code:
--- "templates\items\items.add.tmpl.php" Code:
--- "templates\items\items.edit.tmpl.php" How all the augtypes look http://i.imgur.com/YlZ7E1c.png New Augtypes and add "_copy" to the name of copied items Code:
--- "lib\items.php" This is just showing that an item can have up to 30 for augtype heh... http://i.imgur.com/g1rPzvB.png There is a way to have "Any augment type" which is Augtype -1 but I didn't add that.. but if someone else wants to add it that would be neato :) |
Added with some very minor changes. Thanks!
Will have to discuss the -1 Augment type at some time as well. |
I'm currently having an issue with the PEQ Editor not having a login popup or anything, it is just a picture and the background, nothing more.
http://i.imgur.com/egYdJXt.png |
Discussed above and in the readme: most likely you forgot to turn on short open tags.
|
Would adding spawn2.version to the zonelist be something that would be helpful for anyone?
I have code for it.. just not sure if its too custom or whatever... :p Here is what it looks like.... note I added $version (spawn2) to the searchbar for NPC editing http://i.imgur.com/QFTKiZZ.png |
I have wanted to do something like that, it certainly will help for LDoN. I would definitely be interested in that code for inclusion in SVN.
|
The way I wrote it only works correctly with ... $npc_list = 2;
Gotta figure a way out to make it work with the other way as well.. but my brain huts from lack of sleep.. :p |
Yes, please. I been tinkering with Ikkinz stuff lately and it is apain in the ass to keep some things straight. But how would this code handle quest spawned? still have to hit the base version 0?
|
sorvani: Yes, I would have them under version 0 since they would be npc_types without a spawnpoint in the DB.
NatedogEZ: Share whatever you feel comfortable with. If it still needs work, one of us can finish it up. |
I did something kinda stupid but it is sort of working in my favor lol... was using the variable $version for spawn2 version in the searchbar.. and forgot that npc_types has a version in the field list that uses it as the variable $version (doh)
The default database already has version set to npc_types in different versions which really helps and might be a better way to separate them.. but zone version I think what I wrote though needs to be reconfigured to separate the variables.. so yeah.. doh :p |
Something to keep in mind. version in spawn2 is hard-fast. The server uses it so it has to be correct. However, version in npc_types is only used by us for organizational sake. It doesn't necessarily have to be correct. Meaning, a npc_type could have version in npc_types set to 0, even though it is in version 3 of the zone.
Also, a single NPC can be in multiple versions of a zone if it has multiple spawn points. That's where things get tricky with this :I |
Is there something wrong with the svn? When I try to check out I get
Checkout from https://code.google.com/p/peqphpeditor, revision HEAD, Fully recursive, Externals included Unable to connect to a repository at URL 'https://code.google.com/p/peqphpeditor' Unexpected HTTP status 405 'Method Not Allowed' on '/p/peqphpeditor' Additional errors: OPTIONS request on '/p/peqphpeditor' failed: 405 Method Not Allowed Thanks! |
I'm not having any issues with the SVN. Perhaps you had a connection issue.
|
I was able to update quests from svn. Don't know why peqeditor wouldn't work.
|
Get it from http://peqtgc.com/releases instead of SVN.
|
Got it! And now the SVN works from the resulting directory too.
There seems to be something wrong with the login routine though. I always get an error Invalid login attempt. Bad password from IP: '127.0.0.1'. Username: 'admin' Password: 'password'.; -- admin (18-May-14 15:36:24) But I checked and the password in peq_admin does match md5('password') odds bodkins! Found it in another post. XAMPP defaults to short tags off, turned them on and all is well. |
Does anyone know how I fix this? THis is my first time with the editor... Everything seems setup correctly, but that logs directory doesn't exist on my server... Even after I created it and provided write access to it I couldn't work this out. Thank you!
HTML Code:
Could not create logs/sql_log_08-2014.sql! Make sure the logs directory is writeable by your webserver. |
What is the logs and parent chmod?
|
Quote:
I have no idea... I have even moved the log location in the config file and it's the same thing. There must be a setting somewhere that allows the webserver to write, and until I find that... It won't work. |
Yeah, 755 the folders and 644 the files (if I remember right). Are you running with a different user than the public html owner? Is it outside your public html folder with a symlink?
EDIT: How about give me an ls -al from your editor directory. |
All times are GMT -4. The time now is 06:06 PM. |
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.