EQEmulator Forums

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)
-   Development::GeorgeS's Tools (https://www.eqemulator.org/forums/forumdisplay.php?f=674)
-   -   Updated Tool - EqItems Item Editor (https://www.eqemulator.org/forums/showthread.php?t=21442)

ChaosSlayer 06-26-2008 01:47 AM

Quote:

Originally Posted by GeorgeS (Post 151458)
So that I understand, do you think most people would prefer to use the new Name and ID search fields? It's a big change as you can tell - but I can do this in the next revision no problem. I'll have a go at the coding and see if I can get this to work. Should'nt be very hard - but I'll start a big revision now.


GeorgeS

to be honest I almost NEVER use current search menu on the main panel

99% of the time I click all/all and then go into NAME LIKE "bla"

imho, the only thing what should be left on main panel are search by name or partial ID, all the rest moved inside Advanced window

this is not something i would die over, but since you asked - i support Trev on this one

ChaosSlayer 06-26-2008 01:55 AM

Quote:

Originally Posted by trevius (Post 151455)
You can do that easily if you use the method with Excel that I mentioned above. That is exactly what I did and it took no more than 5 minutes to do.

As for the ranges you are using, that is not the way that most people add new NPCs. I am not really sure why you would want to do it that way. I just use a range that is far above anything currently in PEQ, so in case I ever wanted to add someone else's database to mine, it would make at least that portion of doing it easy without worrying about multiple of the same ID trying to overwrite each other. Like for my database, I started at 2700000, and go up from there. I am up to about 2700700 or so now. It makes it easy for me to find any of my custom NPCs when I need to look for them. Is there a particular reason why you would want to fill in NPC IDs around where the current ones from PEQ are? Sounds to me like you would be better off by a "use next available ID" like what the item editor does when creating item ID numbers.


That becuase MOST people are not making 100% CUSTOM server =)
My Crushbone is so much diffirent from a typical Crushbone you got used to, than if you see it and your jaw don't drop- I will give you a cookie :-D

and important thing that I maintain the order where npc ID ALWAYS falls into range of Zone ID number. So everything in Qeynos Catacombs starts with 45000+

this makes tracking down npcs ULTRA easy
another thing- when I make npcs i keep them in nice organized patterns.
If there are sceletons in zone ranging from lev 1 to lev 8, then this will be put in ids like this:

45001 - lev 1 skely
45002 - lev 2 skely
....
45008 - lev 8 skely

Now goblisn will start from 45011 to 45020 with 2 IDs left empty on PURPOSE, cuase thats where NAMED sceletons gona go when I add them at later date.
Some tiem I on purpose leave holes in ids secuences to put into quest/named mobs as proper by type, so all goblins come in single large chunk and not scatered all over the DB =)

GeorgeS 06-26-2008 09:12 PM

Added an update 14.0.0 which has some of the suggestions added. Spell sorting will be added next.

Everquest Item Editor and Character Inventory Editor
- 14.0.0 - Changed to search by item/id on main screen. Search by class/slot now on advanced page - These were done via requests


GeorgeS

ChaosSlayer 06-26-2008 10:21 PM

George there seem to be some problem with version.

It seem that when say copy an item and the search again, it stats showing multiples of the same item (same name and id) even for items that allreday deleted, and tryign to search again keep showing you items that no longer exists
then after so many search clicks, a msg box pops up saying soemthign abotu must refresh, you click that, click search again and whole thing crashes


also - if posible please get rid of "%%" in the search by name menu =)
i mean put them inside the search comand but do not make us type them in if posible =)

also the LONGEST box with explanation text- could be made shorter =)
like "search by name" "search by id"

GeorgeS 06-26-2008 11:31 PM

Ok tried to reproduce but not getting this problem.

(1) talk me thru the steps exactly so I can reproduce this
(2) Did this happen in the last vers?


GeorgeS


I'll get rid of the % %

ChaosSlayer 06-26-2008 11:41 PM

ahh I see what is happening -you adding items to the list WIHOUT clearing it first.

search for netted
click any of netted items
edit item > click copy
search for netted - your list now DOUBLES in size!
and somewhere past that a crush will follow

basicly any time search is run the list should be cleared automaticly

re: version - it is posible i do not have the version JUST before this one, i have the one BEFORE-BEFORE-this one, and it works fine

GeorgeS 06-26-2008 11:49 PM

Ok I fixed the problem - list is now cleared and problem goes away.

I just u/l the fixes a min ago.

I will also start adding trevius' single page edit of item.. but keep the current one for now.

GeorgeS

ChaosSlayer 06-27-2008 12:04 AM

thanks George!

btw, any chance you could look at adding more char editing options?
stats and deity specificly (since they in a blob file inside DB I cannot get to them via sql browser)

Kayot have made a char editor a WHILE ago as part of his bigger editor (which he never truly finished and was never truly functional), and going everytime i need to edit a char kind of a pain. Perhaps you could find out from him how he did it and add that to your editor =)

this is a low priority request however

GeorgeS 06-27-2008 12:15 AM

yes, blob editing is very possible. In fact I've also made a class to display some of the fields in the server stats program, but certainly can incorporate into the character editing part. Just need time and another 2 arms..:)

GeorgeS

Aonelyn 07-07-2008 09:24 AM

when i use the New edit, it does not allow me to save any changes =/

any ideas?

GeorgeS 07-07-2008 09:33 AM

The new edit (for now) does not save. This edit function was too new and a pre-release if anything. The newest version I have has all that added. It's a bloody big update since the new item editing is very good and improved over the single line editing.

I'll release it this coming sat nite.

GeorgeS

Aonelyn 07-07-2008 10:58 AM

alright, good deal.

Can't wait for this release.

Also, is there a way to choose an items icon with this tool? Or do i need to input the icon number via the database?

GeorgeS 07-07-2008 12:32 PM

It has built in icon selection! (integrated my icon viewer) and item color now.

GeorgeS

ChaosSlayer 07-07-2008 11:45 PM

George, on the subject of icon viewer, I keep trying to get your attention in its own thread but its geting dumped down everytime and I guess you keep missing it =)

Anyway, in its earlier version you had Spell icons there too, but in latest version they dissapeared. Could you get the spell icons back?
thanks =)

GeorgeS 07-08-2008 07:18 PM

Ok , ok, I'll add it in.:)

GeorgeS

Weldarr 07-09-2008 11:51 AM

If you could make it able to be minimized that would rock also =)

Nessful 07-12-2008 09:16 PM

wow
 
This thing is a total mess for me, theres no exit button, i cant make new items, cant save whatever i edit. No offense george. not saying the program is a mess im just saying i probally cant get it going correctly. Please can someone give me a full out tutorial on how to get this thing working properly , thanks.

ChaosSlayer 07-13-2008 12:05 AM

first of all you do NOT want to make a new item
simply becuase an item has SO MANY DATA FIELDS that unless you PROPERLY fill them all your Db will crash. (not to mention that up this day a good dozen of values are still unknown - touching them may result in a Db crash)

thats why you take EXISTING item, make a copy of it, and then modify the copy.

there is no SAVE button neither- ANY change you make is permanent and automatic

for exit- click the X in the conner =)

Nessful 07-13-2008 12:14 AM

For me where is no X button in the corner

Aramid 07-13-2008 12:18 AM

Quote:

Originally Posted by Nessful (Post 152515)
For me where is no X button in the corner

Your right, there is no X in the corner, it's more of a bluish square in the upper right hand corner. If you don't see that, then you don't have your video card set to at least 1024 X 768 which I believe is the minimum requirement to see the entire layout.

GeorgeS 07-13-2008 12:20 PM

Nessful - the issues you name are already mentioned and I'll repeat this once more - the version you have is a TEST version with NO SAVE for the new edit function.

There is NO support for <1024x768 resolution. You need a PC able to run at least that.

I'm polishing up the latest release. A few things still need to be resolved to polish it up. I'll release it asap!
The save function works nicely now and I'm making it a bit more bullet proof.


GeorgeS

GeorgeS 07-13-2008 01:49 PM

Ok folks, after a long and hard effort, the newest version 14.1.2 is out. Please give it a go and see how it works for you.

Use the New Edit button for testing the new item edit. There are many little things there that may take time to discover, but I think it will make item editing a bit easier. The single line "old edit" is still there by request.

GeorgeS

Nessful 07-13-2008 03:55 PM

Gg
 
Good job George thanks so much foradding Save to the item editor you have no idea how much easier it will be now. By the way can you check my thread on Support General Support please? Thanks.

moydock 07-13-2008 04:17 PM

Thanks for your hard work George, this will definitely be very helpful for me.

trevius 07-13-2008 05:13 PM

Woot! I can't wait to check it out. Will download it as soon as I get home! Thanks for all of the work. I am sure there was a ton involved!

ChaosSlayer 07-13-2008 06:48 PM

well looks nice but clicking on items icon produces: "File not found error" followed by a crash

ChaosSlayer 07-13-2008 06:56 PM

another thing- you may want to swap yes and No for NO RENT section around

if you following the logic: No Drop - NO means NOT not drop

oh yeah the outlaying window border is gone again - imposble to exit or what is more important to minimize - all windows should have ability to be minimized imho

GeorgeS 07-13-2008 08:53 PM

Fixed the missing file error, and added a minimize button (top right hand corner). Blue right hand button kills app.

Swapped No Rent prompt as requested

Recent version is live.

GeorgeS

ChaosSlayer 07-13-2008 09:51 PM

thanks you George- no crashes so far.
one thing you may want to notice in Material types #4 is actualy a Monks Gi not a robe.

its rarely noticed cuase in game for some reason it will only show up as Gi only if you are indeed a monk or beastlord

ChaosSlayer 07-13-2008 09:57 PM

ok I think i was wrong on the NO RENT flag - you had right the first time- sorry about that =) I was looking at the wrong item for comparecen

another thing- you may want consider making NEW EDIT window modal - as preventing user to swith back to main window unless you either SAVE or click go back

cuase curently I can swith to main window click soem other item... and then there a potential for total screw up =)

OR make sure that when another item in main window is clicked the NEW EDIT window is fully reloaded. cuase curently atleast name of the item does not realods and mayby some other thigns too

GeorgeS 07-13-2008 11:08 PM

Ok, went into the DB and found norent returns either
0,1 or 255. Now I'm confused.
If norent=0 or 1 then it should display NORENT=NO
If norent=255 then it should display NORENT=YES

is that correct?


Code:

select id,name,norent from items order by norent asc
also

Code:

select norent,COUNT(name) from items group by norent
norent count
0      849
1      40952
255    20467


ChaosSlayer 07-14-2008 12:09 AM

baiscly one the numbers is redundant i belive that both 1 and 255 means RENT (=normal item)

and 0 means NO RENT

easy check for this is:

a Summoned Arrow (well known NO RENT item) field value is = 0
and simple Cloth Cape is = 255

i belive i read somewhere on the forums that ANY values greater than 0 for RENT check automaticly redundant with 1, the field should have been a binary one but somehow was made an integer and was left like that - mayby cuase thats how SOE had it

in short, your program shoudl read as following:

0 - no rent? - YES
1 or 255 - - no rent? - NO

GeorgeS 07-14-2008 12:56 AM

Ok thanks - got it and updated the tool

GeorgeS

trevius 07-14-2008 06:48 AM

Wow GeorgeS! You have really outdone yourself this time :D Nice work!

For an initial release with this much work required, it is already surprisingly close to perfect. Of course, I have a few notes that I wanted to mention that you may want to consider taking a look at.

I also wanted to mention that I too was having the problem with trying to set the icons crashing the program. But, that was easily resolved by running the Register_OCX.bat file that came with this version. Worth noting for anyone who has that issue.

And, I think that leaving the Line Editor is a good idea, because it has the bottom scroll area that lets players edit any of the random or unknown fields that are not included in the new editor. Though, it would probably be very rarely if ever used.

List of minor issues I have found so far:

1. I think it might be useful to adjust how slots are chosen a bit. If it is possible, it would be nice if you could make the drop down box for selecting slots to have check mark fields. This would let you easily select multiple slots. As it is currently, you can only see the first slot that is chosen and this includes the view from the new edit window as well as from the main window for the Item Editor Tool. It is important to see all slots that the item is set to in at least 1 of those 2 places. Also, Deities may need to be setup in a similar way if possible.

2. When I click on the button to select Click Effects, it opens a window, but doesn't automatically load the spell list. I assume you made it that way so you could add a partial name search field so people could load up only what they were looking for or still have the option to load the entire list. That would be useful. I also wanted to mention that after I did Load the Spell List, I click the name Column to sort by name and found that for some reason, it put a bunch of blank rows at the top of the list and I had to scroll down a bit to get to where the actual spell list starts. Not sure what is causing that.

3. In the notes for the Cast Times/Charges Guide, you might want to add a note about Recast Delay being in seconds, since it isn't mentioned there. This might help remove any confusion since the cast times are in milliseconds and Recast Delay is just full seconds.

4. I was pleased to see that using the TAB key to switch between edit fields works nicely. Though, when I got to the section with Accuracy, Shielding, etc, I noticed that hitting TAB caused it to jump around to different fields that were not in the order I thought it should have gone in. If possible, it would be nice to have those in an order. It would also be awesome if using the TAB key to switch fields would also cause the selected field to select the text inside so that you could start typing without having to delete the text currently in that field. The Augments section has this same jumping around issue as well.

5. While testing, I clicked the Bag Type button and saw that it changed the field to a drop down box. Though, the box didn't have a "None" listed in it to set it back to none. I don't think this is very important really, since most people wouldn't even click that unless they were actually wanting to make a bag.

That is all I have found so far. All of them are fairly minor issues and some are more preference than issues even. Pretty amazing for an initial release if you ask me :D


I also wanted to mention that if you would like some custom buttons made for your tool(s), just let me know and I will start working on a set. If you can give me samples of all the buttons you would like designed, I can use those for dimensions to make new ones that can replace them so there is no code editing required. I tried looking through the resource folder in the eqitems folder for the image files that are used for the current buttons, but I could only find other sets of buttons and not the exact set that is currently in use. Not sure where it is pulling them from exactly. If I can figure that out, then I can make a set and test them out and then send them to you.

Here are some examples from a button set I made fully custom for a forum I used to run (so you can get an idea of what I can do):
http://stormhavenserver.com/download...n_examples.jpg

I am pretty decent with Photoshop, so if there are any other things you would like adjusted or made for your tools, let me know and I will make time to get them done.

Thanks again for all of your hard work, GeorgeS!

ChaosSlayer 07-14-2008 09:36 AM

few sugestions.
on the MAIN window in item display section you may want to add 3 things:
Endurance, Endurance regeneration and NO RENT status.

In order to save space I sugest putign them in followign manner:

put NO RENT status info after LORE info
Put Hp, mana and Endurance on same line
Put HP Regen, Mana regen and Endur regen on the same line

note this is for Item Display for main window


and if posible make window itself controlable from a taskbar at the bottom - liek default close/minimize option - it used to have it few version ago

theeris23 07-17-2008 08:29 PM

How do you make an item usable in multiply slots? Everytime in the new editor I try to make a weapon primary and secondary, it uses the last one you entered.

GeorgeS 07-17-2008 10:05 PM

currently only one last slot selected is used. I'll have to code that in and will be in the next release.


GeorgeS

theeris23 07-18-2008 08:38 AM

Cool, thanks George! I though I was missing something!

trevius 07-27-2008 07:28 AM

Hey GeorgeS, I know your tool posts get pretty crowded, so I was wondering if you got a chance to see my post I made a few up from this on 7/15. Mostly just a few minor issues, but I figured you may have just missed the post. And, my offer to create buttons is still there if you want. I could even redo the background layout of the new editor if you ever wanted to move some of the fields around a bit. It wouldn't take me long at all. All I would need is a full size screenshot (or the actual tool) with the new field layout and I can over-lay a new background and position the boarders and stuff so they are all in the right place. The layout is good as it is, but I figured I would offer since you mentioned that part being kinda a pain when you first made the new tool.

GeorgeS 07-27-2008 12:19 PM

Trevius - thanks for the sugestions. I did read the post and will incorporate some of those changes.

The field tab index is a done deal at this point because the property is hard coded and rewriting that would be tedious.

The background picture can be modified. I included the bitmaps in the resources folder. Have a look there and also at the "new_edit_screen.pspimage" paint shop pro file.

Buttons - well that's pretty hard because most of them are compiled as activeX controls (that I wrote), and some are just bitmaps. All buttons need to keep the eq feel as much as possible.

When you have new bitmaps/skins, then pm me with the links.

A newer version will be out soon.
Thanks,
GeorgeS


All times are GMT -4. The time now is 05:32 PM.

Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.