EQEmulator Forums

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)
-   Quests::Q&A (https://www.eqemulator.org/forums/forumdisplay.php?f=599)
-   -   Class Specific quest (https://www.eqemulator.org/forums/showthread.php?t=20405)

paaco 04-23-2006 01:19 PM

Class Specific quest
 
I am attempting to make a quest in my noobie zone that gives class specific rewards. However when you hail him, he gives you the text, but then when you hand him a mold for your wep he does nothing :( Can anyone tell me what is wrong in the format for this? Thank you any that can reply and help me get this working. :)

Code:

sub EVENT_SAY {
    if ($text=~/hail/i) {
      quest::say("Hello $name , I am one of the finest weaponsmiths this land has ever seen. If you find me a mold I will craft you a weapon. However if it is armor you seek, my brother makes the best around.");}
    }
   
sub EVENT_ITEM {
  if ($class == Warrior)
    (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    elsif ($class == Paladin)
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    elsif ($class == Shadow Knight) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    elsif ($class == Berserker) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    elsif ($class == Monk) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(6611);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    elsif ($class == Beastlord) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(6611);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    elsif ($class == Druid) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    elsif ($class == Necromancer) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }   
    elsif ($class == Wizard) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    elsif ($class == Magician) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    elsif ($class == Enchanter) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    elsif ($class == Shaman) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    elsif ($class == Cleric) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29442);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    else {
      plugin::return_items(\%itemcount);
      quest::say("These are not the pieces I need.");
  }
}

Also note that I have tried this with the class name typed out like in my posted code. and with the class ID#. Same result both ways.
elsif ($class == Paladin)

fathernitwit 04-24-2006 02:06 AM

if($class == "Warrior")

missing quotes

Muuss 04-24-2006 02:16 AM

Code:

sub EVENT_ITEM {
  if ($class == Warrior)
    (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }

missing && between $class=="Warrior" and the check_handin
or miswritten tests.

I would write it that way :

Code:

sub EVENT_ITEM {
  if (($class == "Warrior") && (plugin::check_handin(\%itemcount, 6164 => 1))) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }

  if (($class == "Paladin") && (plugin::check_handin(\%itemcount, 6164 => 1))) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }

  ...
  ...
  plugin::return_items(\%itemcount);
}


Muuss 04-24-2006 02:25 AM

Forgot to write this, after you wrote a quest, you can test its syntax with perl :

Code:

perl -cw 'questfile.pl'
This will help you to fix some of the errors you made.

Muuss 04-24-2006 04:25 AM

What i wrote previously has a correct syntax but won't work due to recent changes in the plugin::check_handin method.

You MUST write your quest like that :

Code:

sub EVENT_ITEM {
  if ($class =="Warrior") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      ... do stuff here
    }
  }

  if ($class == "Paladin") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      ... do stuff here
    }
  }

  ...
  ...

  plugin::return_items(\%itemcount);
}

In my previous code, the test for the paladin would never be valid because the item will disappear of the list during the warrior's test. I m still not used to that new check_handin, sorry for the error :)

paaco 04-24-2006 05:20 AM

Thanks a lot guys, With the info you gave I'm sure I can get it working. :)

paaco 04-24-2006 06:18 AM

After updating my quest to what you guys suggested It still doesn't want to work. Any more suggestions? Or maybe I overloocked something.

Code:

sub EVENT_SAY {
    if ($text=~/hail/i) {
      quest::say("Hello $name , I am one of the finest weaponsmiths this land has ever seen. If you find me a mold I will craft you a weapon. However if it is armor you seek, my brother makes the best around."); }
    }
   
sub EVENT_ITEM {
  if ($class =="Warrior") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class == "Paladin")
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class == "Shadow Knight") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class == "Berserker") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class == "Monk") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(6611);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class == "Beastlord") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(6611);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class == "Druid") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class == "Necromancer") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }   
  if ($class == "Wizard") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class == "Magician") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class == "Enchanter") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class == "Shaman") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class == "Cleric") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29442);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
    else {
      plugin::return_items(\%itemcount);
      quest::say("These are not the pieces I need.");
  }
}


jimbabwe 04-24-2006 06:58 AM

you were missing a bracket in the paladin's code

Code:

sub EVENT_SAY
{
            if ($text=~/hail/i)
        {
                      quest::say("Hello $name , I am one of the finest weaponsmiths this land has ever seen. If you find me a mold I will craft you a weapon. However if it is armor you seek, my brother makes the best around.");
        }
}
   
sub EVENT_ITEM
{
        if ($class =="Warrior")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                      quest::summonitem(62189);
                      quest::exp(750);
                      quest::emote("smiles warmly as he hands you your weapon.");
                      quest::ding();
                    }
            }

          if ($class == "Paladin")
            {
                if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(62189);
                        quest::exp(750);
                        quest::emote("smiles warmly as he hands you your weapon.");
                        quest::ding();
                    }
            }
        if ($class == "Shadow Knight")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(62189);
                              quest::exp(750);
                              quest::emote("smiles warmly as he hands you your weapon.");
                              quest::ding();
                    }
            }
          if ($class == "Berserker")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(62189);
                              quest::exp(750);
                              quest::emote("smiles warmly as he hands you your weapon.");
                              quest::ding();
                    }
            }
          if ($class == "Monk")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(6611);
                              quest::exp(750);
                              quest::emote("smiles warmly as he hands you your weapon.");
                              quest::ding();
                    }
            }
          if ($class == "Beastlord")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(6611);
                              quest::exp(750);
                              quest::emote("smiles warmly as he hands you your weapon.");
                              quest::ding();
                    }
            }
          if ($class == "Druid")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(29422);
                              quest::exp(750);
                              quest::emote("smiles warmly as he hands you your weapon.");
                              quest::ding();
                    }
            }
          if ($class == "Necromancer")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(29422);
                              quest::exp(750);
                              quest::emote("smiles warmly as he hands you your weapon.");
                              quest::ding();
                    }
            }   
          if ($class == "Wizard")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(29422);
                        quest::exp(750);
                              quest::emote("smiles warmly as he hands you your weapon.");
                              quest::ding();
                    }
            }
          if ($class == "Magician")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(29422);
                              quest::exp(750);
                              quest::emote("smiles warmly as he hands you your weapon.");
                              quest::ding();
                    }
            }
          if ($class == "Enchanter")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(29422);
                              quest::exp(750);
                              quest::emote("smiles warmly as he hands you your weapon.");
                              quest::ding();
                    }
            }
          if ($class == "Shaman")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(29422);
                              quest::exp(750);
                              quest::emote("smiles warmly as he hands you your weapon.");
                              quest::ding();
                    }
            }
          if ($class == "Cleric")
        {
                    if (plugin::check_handin(\%itemcount, 6164 => 1))
                {
                              quest::summonitem(29442);
                              quest::exp(750);
                              quest::emote("smiles warmly as he hands you your weapon.");
                              quest::ding();
                    }
            }
            else
        {
                      plugin::return_items(\%itemcount);
                      quest::say("These are not the pieces I need.");
          }
}

You may try formatting your code like that as it can be a lot easier to keep track of brackets and code segments.

Cisyouc 04-24-2006 07:04 AM

Aren't you supposed to use the eq operator and not the == operator for strings?

if($class eq 'Warrior') { /* ... */ }

Muuss 04-24-2006 08:12 AM

Using eq instead of == is a good idea, yes :)

About the else at the end of your code. It has no sense.

just add plugin::return_items(\%itemcount); without test.

check_handin verifies that you gave the right amount of items and removes them of the list of given items.

At the end of the quest, you call return_items to give back to the player each item that remains in the list. Don't include it in a test, just do it or don't do it.

paaco 04-24-2006 08:58 AM

The quest works now, thank all of you guys for your hard work and patience helping me get it going. Posting the working code, maybe it will help someone else looking to make a class specific quest.

Code:

sub EVENT_SAY {
    if ($text=~/hail/i) {
      quest::say("Hello $name , I am one of the finest weaponsmiths this land has ever seen. If you find me a mold I will craft you a weapon. However if it is armor you seek, my brother makes the best around.");}
    }
   
sub EVENT_ITEM {
  if ($class eq "Warrior") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class eq "Paladin") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class eq "Shadow Knight") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class eq "Berserker") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class eq "Monk") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(6611);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class eq "Beastlord") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(6611);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class eq "Druid") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class eq "Necromancer") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }   
  if ($class eq "Wizard") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class eq "Magician") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class eq "Enchanter") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class eq "Shaman") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
  if ($class eq "Cleric") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29442);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding();
    }
    }
      plugin::return_items(\%itemcount);
      quest::say("These are not the pieces I need.");
  }
}


paaco 04-24-2006 09:20 AM

ok actually it doesn't work lol. This quest is starting to get old :( When you hand in the item now this stuff happens:
quest::exp(750);
quest::emote("smiles warmly as he hands you your weapon.");
quest::ding();

But instead of summoning the correct item for you, he hands you back the mold and says:
These are not the pieces I need.

So basically you can stand there and hand the mold in over and over until you reach max lvl if you want to do 10k turnins =/

jimbabwe 04-24-2006 12:02 PM

i got it working, let me finish it and i'll post it

jimbabwe 04-24-2006 01:00 PM

I added a few comments into the file for you, so you can tweak usability.

Code:

#this quest will work for any class as is, however it just gives xp to rogues, rangers, and bards
#this can be fixed by moving the emote, exp and ding functions into the if statements individually.
sub EVENT_SAY
{
            if ($text=~/hail/i)
        {
              quest::say("Hello $name , I am one of the finest weaponsmiths this land has ever seen. If you find me a mold I will craft you a weapon. However if it is armor you seek, my brother makes the best around.");
        }
}
   
sub EVENT_ITEM
{
        if (plugin::check_handin(\%itemcount, 6164 => 1))
        {
                if(($class eq "Warrior") || ($class eq "Paladin") || ($class eq "Shadowknight") || ($class eq "Berserker"))
                {
                        quest::summonitem('62189');
                }
                if(($class eq "Monk") || ($class eq "Beastlord"))
                {
                        quest::summonitem('6611');
                }
                if(($class eq "Druid") || ($class eq "Necromancer") || ($class eq "Magician") || ($class eq "Wizard") || ($class eq "Enchanter") || ($class eq "Cleric"))
                {
                        quest::summonitem('29442');
                }
                quest::emote("smiles warmly as he hands you your weapon.");
                quest::exp(750);
                quest::ding();
            }
        elsif(plugin::return_items(\%itemcount))
        {
                #this command isn't working.  maybe quest::return_items returns a false value when it gives soemthing back.
                quest::say("These are not the pieces I need.");
        }
}


EDIT: oh, I only tested this on bards, warriors, and wizards... could be bugs.

paaco 04-24-2006 01:06 PM

Nice, thank you Jimbabwe, I'll try this out :)


All times are GMT -4. The time now is 03:05 AM.

Powered by vBulletin®, Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.