EQEmulator Forums - Quest I made ( needs critiqueing)

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)

- Quests::Q&A (https://www.eqemulator.org/forums/forumdisplay.php?f=599)

- - Quest I made ( needs critiqueing) (https://www.eqemulator.org/forums/showthread.php?t=17739)

Quest I made ( needs critiqueing)

Code:

sub event_say {

if($text=~/Hail/i){

quest::say("Hello friend, my name is Jeweler Rashard. I will [craft]items for a small fee.");

}

if($text=~/craft/i){

quest::say("Yes, I will craft [jewelry], and imbue some [wepaons] with gems.");

}

if ($text=~/jewelry/i){

quest::say("I can craft [rings],[earrings] and [amulets].");

}

if ($text=~/earrings/i){

questsay::("I can craft, you a magical [Hoop of Dark Spirits], All I require is a mithril earing, and a jacnith. I will also require 500pp for my work.");

}

if ($text=~/rings/i){

questsay::("You would like a ring? Well I can craft you a ring of dreadful dreams. For this magical ring I require a dream stone, and a silver emerald ring. I will also require 1000 platinum peices for my work.");

}

if ($text=~/amulets/i){

questsay::("Oh, you want an amulet? Well I will need a saphire, and a mithril amulet. Also, I require 950 platinum peice for my work.);

}

if ($text=~/weapons/i){

questsay::("Oh, you would like a magically imbued weapon, Well I can craft a [bow], and a [sword]..");

}

if ($text=~/bow/i){

questsay::("Oh you would like a bow? Well I require a hunting bow, and a blue diamond. Also I will need 2,4000 platinum peices for my work.");

}

if ($text=~/sword/i){

questsay::("Oh, you would like a sword? Well in order for me to make a sword, I need a fine steel short sword, and a blue diamond. Also I require 2100 platinum pieces for my work.");

}



sub EVENT_ITEM

{

#rin

if ($platinum == 1000 &&  $itemcount{26909} == 1  &&  $itemcount{14464} == 1){

quest::text ("Here is your new ring, I hope you enjoy it.");

quest::summonitem (27950);

}

#earring

if ($platinum == 500 &&  $itemcount{10041} == 1  &&  $itemcount{10053} == 1){

quest::text ("Here is your new earring.");

quest::summonitem(4334);

}

#necklace

if ($platinum == 950 &&  $itemcount{10047} == 1  &&  $itemcount{10034} == 1){

quest::summonitem(30351);

}

#bow

if ($platinum == 2400 &&  $itemcount{8011} == 1  &&  $itemcount{22503} == 1){

quest::summonitem(45050);

}

#sword

if ($platinum == 2100 &&  $itemcount{5352} == 1  &&  $itemcount{22503} == 1){

quest::summonitem(70006);

}

I havent gotten to test it out yet, Im almost positive I did the sub even item things wrong, but did it the best I could. Any help / suggestions / fixes on quest would be appreciated.

Been looking at your quest and found a few errors.

Remember syntax : ), sub EVENT_SAY has a { correct? Where is the one ending the sub event?

Should be after he last function.

It should be quest::say, not questsay::
if ($text=~/earrings/i){
questsay::("I can craft, you a magical [Hoop of Dark Spirits], All I require is a mithril earing, and a jacnith. I will also require 500pp for my work.");
}
if ($text=~/rings/i){
questsay::("You would like a ring? Well I can craft you a ring of dreadful dreams. For this magical ring I require a dream stone, and a silver emerald ring. I will also require 1000 platinum peices for my work.");
}

Hoop of Dark Spirits, you put brackets around it as if they were supposed to say something, but you stopped there?

sub EVENT_ITEM needs a bracket to close it also
sub EVENT_ITEM
{
}
Also, how I would organize my code is like this:
*Note* There are spaces in there, the forum just deleted them.
sub EVENT_SAY
{
if($text=~/hail/i)
{
quest::say("Hullo.");
}
}
As you can see, it is a lot easier to tell what brackets are matched up with what. Just tab every time you have a new thing, such as

x=0;
sub EVENT_SAY
{
if(text=~/hail/i)
{
if($race == "Dwarf")
{
quest::say("Good dwarf, leave me be.");
}
}
}
Also, don't forget elsif, it is much better for coding:
if()
elsif()
else()

Hope I helped : )