Haste/Slow not working on NPCs
I think I've found the issue with this, slow / haste will not apply until the NPC changes targets.
Code:
void NPC::SetTarget(Mob* mob) { Change Mob::CalcBonuses() to Code:
void Mob::CalcBonuses() in Mob::_GetMovementSpeed() find: Code:
int movemod = spellbonuses.movementspeed + itembonuses.movementspeed + mod; Code:
int movemod = spellbonuses.movementspeed + itembonuses.movementspeed + mod; |
Was this noticed? I'm playing with 878 and none of my shaman's slows appear to work. I set up a level 50 shammy and cast the level 36(?) spell on a newbie mob - no change in attack speed.
|
This should be fixed, though I changed how haste was calculated the other day, I'll have a look at it tonight to make sure I didn't mess anything up.
|
I can verify slow was fixed for a while, but stopped working as of .878 I have not tested .882 yet, the 11/02 post.
|
Doesn't work as of the latest source, looking for the cause atm. Haste works but slow doesn't.. never saw anything like this when I was first testing haste changes, obviously something was fubared in the process.
|
Gremlins, they sneak up on ya.
|
I found what was wrong, really it was the entire implementation, should get a fixed version in as soon as I get an OK from a dev.
|
Should be fixed now with the source/binaries posted tonight.
|
Cool. I just tried 898 and figured out that the mobs were being hasted by slows 8)
|
Quote:
|
In 898 - the one I downloaded this morning
|
Yeah the problem was 2 fold really, mostly inexperience with how haste was handled with bonuses by me, and no one really caught it when I submitted it to review. Essentially every haste was being calculated at (hasted%+100%) so a -30% slow was really a 70% haste cause of my screw up. And my code didn't totally overlooked slows when comparing it to the base value of 0(lol).
|
Yeah but the real screw up was that you found it right away. You're supposed to be so caffinated that you work feverishly to find the problem for 28 hours straight - until you collapse from exhaustion and caffine overdose - then when you wake up and sit down in front of the computer again, you see the mistake in the first line of code.
At least, thats the way its supposed to work! |
Yea, I fixed it up so that its calculated correctly, and there were a few other things that I fixed as well like V3 Haste does not have the +100 on its effect value, and bard skills should not affect the haste %, and haste should not be applied at all if slowed.
|
Grabbed it this morning and it appears to be working. However, and this is just a first impression, it appears that the haste wears off faster than the 3:30 listed (perhaps that's 3:30 at level 50?). Also, the first time I slow a mob it seems to go slower than a re-slow. So a gnoll that hit me about every 3 seconds went to 7 seconds with the first slow and five seconds in the subsequent re-slow. I'll have to try this a few more times to make sure its not just me and my inconsistant 1 steamboat 2 steamboat counting ;)
|
All times are GMT -4. The time now is 09:54 PM. |
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.