Resurrection Effects:
 

Heya.

Just thought I'd make a quick post about two spells that I've noticed issues with. It seems that both Customer Service Resurrect and Divine Resurrect give Resurrection Effects as a debuff once the rez is accepted. Hadn't ever noticed this before because it was only recently that Derision's handy dandy pop-up windows made Rezzing worth paying attention to.

Both give the correct text in the pop-up window (100% XP and the right spell name), so they aren't getting crossed anywhere. I'd imagine that there's some part of the code that deals with people being rezzed, and automatically slaps Resurrection Effects on them when it happens. Sometime down the line, this will have to have an exception put into place.

Oh, and I know it's already been reported, but Resurrection Effects can be dispelled, which severely lessens its intended affect. Is that something that's dealt with in the spell file that we can't easily touch? Or is it code-based somewhere?

Thanks for any feedback on either of these issues, anyone.

If these spells shouldn't give Rez effects:

in zone/client_process.cpp, void Client::OPRezzAnswer(const EQApplicationPacket* app),

around line 943, try changing

to:

Untested.

I think it would be nice if server code could recognize these spells by some OTHER value rather than the spell id#.
What if I want to have OTHER spell wihout rezurection sickness effect?
What if I am using a totaly diffirent spell file where these id correspand to nuke and levitation?

IMHO we should have a Rule to turn rez sickness effects on and off for all spells (so i can make all rez spells on my server sickness free)

I was doing some digging into this, but it looks like there really isn't much that sets those spells apart from the regular rezzes in the spells_us.txt file:
Well, if you're going through all the trouble to create a spell file, you could just make the changes in the source (and make sure to change it again if/when you update the server code).

Flexibility is good, so I can agree to that. Adding the check is easy:
Then you just need to add the rule in the code, which isn't hard.

In common/ruletypes.h, around line 117, add:
Then, you can add the rule into the database:
And now you have the option to turn rez effects off.

Great work Andmetal! I hope the new rule would ne added to the code =)


BUT I have an idea how to make those spells stand out.

we need to make rule: Special Rez spell Id: (x,x,x)

how about that?

them wihout altering the code the special spells can be listed in rules and code can adress them by whatever ID numbers entered there rather than have spell ID hard coded into the source

I belive that all AA and discplines also have hard coded spell ids?
I think we should make a separate table which would store ID to ABility/AA corespandance so in a custom spell file I coudl set for exmaple soem monk special discipline to point to some other spell wihout touching the code itself

this woudl give me option fo complitly wiping the original spell file and build a new one where say all heals go one by one rather than been scatered all over the file, wihout having to go around hard coded spells cuase I can't touch their ID#

think about this one =)

I took a look at this and noticed something. There is a difference between the spells with Resurrection Effects and those that don't. However they are currently in "spacing158" fields.

If you look in spdat.h at the SPDat_Spell_Struct:
Which probably means we don't know what they are.

In spells_us.txt those fields are:
The spells with spacing158_1 set to 42 are:
But the spells with spacing158_3 set to 82 are:
which look to be the ones we want.

My guess is spacing158_3 is a super class of beneficial spells and spacing158_4 is a subclass.

However, the rule you are looking for is:

The completely untested code

In /zone/spdat.h
~line 388
~ line 453
and in /zone/net.cpp
~line 984
and then in /zone/client_process.cpp
~ line 943

There was a typo (although it probably wouldn't have effected anything):

and in /zone/net.cpp
~line 984

I would like to make a somewhat major clarification: those values are actually in fields 156 (typedescnum) & 157 (effectdescnum), not 160 & 161 (still unknown, and all 0's for the resurrection spells).

However, they could definitely be used to separate out normal rez spells from ones that don't have a rez effect, since the ones without rez effects don't use either.

For reference, here are the IDs, from dbstr_us.txt, that correspond to both:
Anyways, as long as you change the code to check if spells.effectdescnum == 82, it should be fine. The only thing I'm not sure about is the best way to pull the spell data using ra->spellid.

Thanks AndMetal, good catch. I managed to add some columns in my spreadsheet throwing everything off. And I don't know what I was thinking with the OPRezzAnswer bit. I obviously didn't have enough coffee yesterday. Wish I could go back and edit/delete those old posts.

You could add to spdat.h something like:
and to spdat.cpp

and then just use that in the client_process.cpp. However, if I were to rewrite this chunk of code, I would make a SpellFactory, which would have a method "getSpellById( int16 spell_id)" and have that return an instance of a class Spell. The class Spell would have accessor methods for things like GetEffectDescNum(). The laundry list of "IsWhatever(int spell_id)" is getting out of control.

I will have a look at implementing the changes discussed on this thread today. Should CSR and Divine Resurrect Rez the player with 100% HP and Mana as well as no Rez effects ?

If you want it to match Live, then yes. CSR Res stores 100% hp and mana.