PC main and second hand attacks
This is the main hand and secondary hand client attack logic from the client_process.cpp file starting at line 253 in the 1129 source. I've indicated in blue text a couple of places I think code should be added and in red text some code I think should be deleted.
For the primary hand, I added a check for the Raging Flurry AA that says its bonus should only be calculated on a successful tripple attack. Currently it always adds the bonus. The red text i think should be deleted because it is checking for Flurry AA on secondary hand and I think the Flurry attack is primary hand only. Also deleting the call to some Necromancer AA 183? that would never get called in an offhand attack. It may have been for the Raging Flurry but got changed to 183. So if I'm wrong about offhand flurry's, then maybe the 183 should be change to aaRagingFlurry. Additionally the bonus is different for main hand Flurry than it is for offhand flurry... 15, 30, 50 instead of 10, 20, 30. The AA check for Ambidexterity I also want to delete in the if for dual wield. There's a bonus calculation right above it, but it ignores the bonus anyway and just plain gives you automatic dual wield on the secondary hand if you have this aa and it doesn't make any sense. The dualwield check also adds in the itembonus and spellbonus, but GetSkill also adds in the item bonus so I think GetRawSkill should be used instead. There's also an extra check for dual wield skill increase that should be deleted. Should secondary hand get triple attack? Am I correct about secondary hand not supposed to get flurry? Code:
if (auto_attack && target != NULL && may_use_attacks && attack_timer.Check()) { |
I made an error on the secondary hand... the check for increase in dual_wield skill needs to change. You can get a skill up even if you don't succeed in dual wielding so delete in red... add(leave it there) in blue:
Code:
float random = MakeRandomFloat(0, 1); |
GetSkill() and GetRawSkill(). Don't change it to GetRawSkill(). It seems that
Code:
itembonuses.skillmod[DUAL_WIELD] Code:
itembonuses.DualWeildChance |
KLS asked to make cut/paste easier, so here's this suggested way:
find client_process.cpp lines 276-277 Code:
// Kaiyodo - support for double attack. Chance based on formula from Monkly business Code:
// Kaiyodo - support for double attack. Chance based on formula from Monkly business Code:
&& CheckDoubleAttack(false,true)) Code:
&& CheckDoubleAttack(false,true)) Code:
switch (GetAA(aaRagingFlurry)) { Code:
if(tripleAttackSuccess) { Code:
float random = MakeRandomFloat(0, 1); Code:
float random = MakeRandomFloat(0, 1); Code:
CheckIncreaseSkill(DUAL_WIELD); Code:
if (target && GetAA(aaFlurry) > 0) { Let me know if this works for you KLS or if there is still a better way? I don't know how to make a 'diff file' but would be willing to learn if that makes it easier on you. |
All times are GMT -4. The time now is 09:31 AM. |
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.