EQEmulator Forums - What is wrong with this? Super simple

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)

- Quests::Q&A (https://www.eqemulator.org/forums/forumdisplay.php?f=599)

- - What is wrong with this? Super simple (https://www.eqemulator.org/forums/showthread.php?t=31247)

What is wrong with this? Super simple

PHP Code:


		
			
sub EVENT_SAY {
if(($text=~/hail/i) && (defined($qglobals{illsalin})) && ($qglobals{illsalin} == 0)){
$client->Message(5,"Have you heard of the new [tyrant] of Last World?");
quest::setglobal("illsalin","1","5","F");
}
elsif(($text=~/tyrant/i) && (defined($qglobals{illsalin})) && ($qglobals{illsalin} == 1)){ 
$client->Message(5,"His name is Vertallis, he is a monstrosity from another realm who subsides in the Caves of Time. He holds the key to the next realm of [adventure]...");
}
elsif(($text=~/adventure/i) && (defined($qglobals{illsalin})) && ($qglobals{illsalin} == 1)){
$client->Message(5,"Yes, the ancient Ruins of Illsalin. Deep within the ruins dwells creatures beyond any power you have ever seen...you must gain access to these ruins. One of adventurers went there several seasons back and has never returned...he could be alive. Poor Daemonloth...");
}

I dont understand why this simple script doesnt work? It's a hail to set globals - thats it. I've written tons of scripts its just that there must be a space somewhere im not seeing or something.... quite irritating actually. Maybe someone sees something i dont - Thanks for your time.

Just to eliminate some things - .pl file is named correctly, in correct file - npcs globals are turned on and everything. When you hail, he does nothing.

Also I've used the global check for "Zero" before and never had problems - but to be sure i removed it and just put if hailed = then he says stuff.... still nothing? I dont understand.

You're missing a curly bracket here.

Code:

sub EVENT_SAY {

if(($text=~/hail/i) && (defined($qglobals{illsalin})) && ($qglobals{illsalin} == 0)){

$client->Message(5,"Have you heard of the new [tyrant] of Last World?");

quest::setglobal("illsalin","1","5","F");

}

elsif(($text=~/tyrant/i) && (defined($qglobals{illsalin})) && ($qglobals{illsalin} == 1)){ 

$client->Message(5,"His name is Vertallis, he is a monstrosity from another realm who subsides in the Caves of Time. He holds the key to the next realm of [adventure]...");

}

elsif(($text=~/adventure/i) && (defined($qglobals{illsalin})) && ($qglobals{illsalin} == 1)){

$client->Message(5,"Yes, the ancient Ruins of Illsalin. Deep within the ruins dwells creatures beyond any power you have ever seen...you must gain access to these ruins. One of adventurers went there several seasons back and has never returned...he could be alive. Poor Daemonloth...");

} 

}

Okay well i didnt copy and paste the last bracket - but it is there - sorry. Good lookin out though.

Try this:

Code:

sub EVENT_SAY {

  if($text=~/hail/i) {

    if(!defined($qglobals{illsalin})) {

      $client->Message(5,"Have you heard of the new [tyrant] of Last World?");

      quest::setglobal("illsalin",1,5,"F");

    }

    else {

      quest::say("Welcome back, $name. Do you need to hear about the [tyrant] Vertallis again?");

    }

  }

  if(($text=~/tyrant/i) && (defined($qglobals{illsalin})) && ($qglobals{illsalin} == 1)) {

    $client->Message(5,"His name is Vertallis, he is a monstrosity from another realm who subsides in the Caves of Time. He holds the key to the next realm of [adventure]...");

  }

  elsif(($text=~/adventure/i) && (defined($qglobals{illsalin})) && ($qglobals{illsalin} == 1)) {

    $client->Message(5,"Yes, the ancient Ruins of Illsalin. Deep within the ruins dwells creatures beyond any power you have ever seen...you must gain access to these ruins. One of adventurers went there several seasons back and has never returned...he could be alive. Poor Daemonloth...");

  }

}

If it still doesn't work, then it is somewhere else in the file that is broken.

This is assuming, as you said above, that this NPC has qglobals set to 1 in the database.

I'll give it a shot - also do you know of a way to reset script on mob without restarting? Cuz i got like 30 players on my server on average so i dont wanna keep restarting - Only asking cuz I never tried. Thanks

#reloadpl will save me so much time =) Thank you. Also for the portion that jolligoro submitted - when i hail him he says the quest::say part and doesnt respon to "tyrant" at all....? Im wondering why any of the;

$client->Message(5,"Have you heard of the new [tyrant] of Last World?");

arent working? I just dont understand... the syntax/text everything is exactly the same as working quests - is there some plugin fix or something? Not quite sure what to do to fix - Thanks.

nvm I figured it out - just missing some brackets - Thanks

http://ult-tex.net/tools/ultra/line_count.pl

i like to use this if i wanna check for syntax errors :)