Can I get another set of eyes on these quests?
 

For some reason they aren't working completely so hoping another set of eyes can spot any errors:

First quest, so far the dialogue is working fine but I'm getting repeats of some messages and when I turn in items I'm getting the item return message even though the turn in is correct (and fires correctly).

Second quest, none of the dialogue is working. The turnins work but getting the same issue as first quest.

In the second quest you have $hateblade as a saylink, that might be screwing up your qglobal check and breaking the dialogue.

That got his dialogue working, now the saylink for [$potential] isn't working. All I get is []. I've tried changing the words around and using different saylinks and get the same result.

The handins work too but I'm still getting the "item returned" message even though the handins were successful.

That's because you are defining saylinks with the 'my' which declares variables only to the enclosing block, meaning they will not traverse outside of the block you have them defined. Right now they are defined at the top level block of the sub EVENT_SAY routine and they will flow through the entire say dialogue just fine. If you take out 'my' and say in a specific situation where a player goes in to that zone, and that script was cleanly loaded and they tried to hand in items it wouldn't work either because they did not speak to the NPC to define those variables at the top of the sub routine. If you are going to pass saylink variables throughout the entire script it is better to put them all in sub EVENT_SPAWN because variables will be defined on spawn. Otherwise if you only need that saylink in sub EVENT_ITEM, simply define it within the sub EVENT_ITEM block.

Does this answer your questions and issues?

Let me know.

~Akkadius

Definitely. This is my first time writing this kind of quest and first time putting a saylink within the items portion. How do I set them inside the spawn event block so they work in other event blocks?

Can you shed any light on why my successful handins are giving me the items returned message though?

Appreciate the info.

First of all you are trying to access your qglobal like it is a local variable defined, in which under your sub EVENT_SAY you have $hateblade defined as a saylink.

To access your qglobal it needs to be accessed as such:

Ex:
Help?

Also you can debug your quests by spitting out what the value of your qglobal actually holds by doing this:

In your example:

elsif(plugin::check_handin(\%itemcount, 2668=>1) && $qglobals{"hateblade"} == 4})

Where is that other bracket coming from?

Below is the updated trader quest. I moved the saylink to the item section.

Still existing issues: Whenever I hand the platinum to the trader I get the failed turn in message even though the turn in is successful (and I get the global).

Once I have hateblade==1 flag, I'm getting 4 messages when I hail the trader. The messages for hateblade==0 and the messages for hateblade==1. Why is this? I've tried using !defined, hateblade==undef, and hateblade==0. No matter which I use my warrior is sitll getting 4 messages.

I have a shaman standing nearby who is only receiving the first message (which is perfect).

You need to think a little about how if/else works. The else you have will happen if the last if isn't true. If you want it to only happen if all of the other checks fail you need to use if/elsif/else all the way through.

Another thing that might be easier to debug would be to group some things together. Like if($text=~/hail/i) and then check all the qglobal values inside that if. You could also group some together, like if($globals{"hateblade"} >= 5 && $globals{"hateblade"} <= 7), etc.

If you're seeing more than one response, add some debugging to the script. Print out what the qglobal is set to and it will help you determine where things are going wrong.

Using your suggestions, now I'm not getting any responses for anything except hateblade==0. The debugger on my warrior comes back 1, and he still receives 0 responses. My shaman receives a blank response and receives the 0 else response.

ARGH!

Just started looking at your conversation. Is qglobals set to 1 on this NPC in the npc_types table?

Oh, and you don't need quotes in your $qglobals{hateblade}

Yes, the quotes don't seem to hurt anything. :-D

I know, just letting you know you don't need them.

Missing the "Q" in $qglobals will mess things all up though.

See that's why it's always nice to get a second set of eyes on your work lol.

Both quests work great now. Thanks everyone!