EXP modifier patch
 

This is my first attempt at modifying the code, so please go easy on me. :)

This is just a bit of code to allow admins to modify the amount of EXP earned, AAEXP earned, and the EXP bonus for each additional member of the group. If this is something people want, I'd like to expand it to include Quest EXP vs. Mob EXP, death penalties, mob stats and other balancing issues as well. All of these would be controlled through table entries so that admins could make some balance changes without deciphering the source and recompiling.

The current entries are all controlled through the variables table

• GroupEXPBonus = EXP modifier for each member of group (default = .1)
  
  EXPMod = EXP earned multiplier in GetEXP (default = 1.0)
  
  AAXPMod = AAXP earned multiplier in GetEXP (default = 1.0)

Anyway here's a diff against the zone directory vs 0.4.4-DR1.

I'm not much of a C++ programmer, and do development on Linux so I'm not making any promises. Any feedback or other project ideas are welcome.


Kaldec

If quest XP can be done then would it be possible to make it worthwhile to quest for XP?

This was one of the biggest flaws in EQ...most quests except epics are way too bothersome comparing risk vs. reward and the XP rewarded is close to non-existant at most, making XP groups and boss-killing a lot more rewarding than questing.

Having quests give a lot of XP would make them more appealing.

I think its a great idea.

If you make sure values set at 1 make it look like it does today, I'll merge it in.

Any change that makes a paramter tunable without needing to be recompiled is a valuable addition. That way you can speed up/slow down progression on your server without going through to much pain.

Sounds good.

I'll see if I can figure out how to separate questing and fighting tonight, and run some tests.

The XP bonus's for groups are as follows:

2 person group - 2% total bonus.
3 person group - 6% total bonus.
4 person group - 10% total bonus.
5 person group - 14% total bonus.
6 person group - 20% total bonus.

Don't know if this is possible in the GroupEXPBonus though, not had a look at it.

I apologize for not linking to something this large, I'll do so in the future. I did update the diff against a new CVS grab tonight.

I've implemented the following variables that can be included in the variables table as double values (i..e 3.0, .04, 13.0, ...):

NPCEXPMod: Multiple for exp gained from killing NPCs (default=1.0)

PCEXPMod: Multiple for exp gained from killing PCs (default=1.0)

QuestEXPMod: Multiple for exp gained from quests (both systems) (default=1.0)

AAXPMod: Multiple for AAXP gained by any means (default=1.0)

GroupEXPBonus: Group EXP bonus per member (default=.1)

EXPPenaltyMod: Modifier to EXP lost upon death (default=1.0)

If these fields are added to the variables table, the value set will be used, otherwise the default value will be used. I've verified that the default value is setup correctly in the absence of these fields. I've also verified that the default values for NPCEXPMod, QuestEXPMod, and EXPPenaltyMod do not affect the end results of those actions. The changes were the same in all cases, so I didn't go to the trouble of setting up a second account to test the GroupEXPBonus.

Some things to consider when using this:

* The NPCEXPMod and PCEXPMod are applied before a chunk of EXP is passed to a group instead of being applied to each individuals gain, I'm not sure what if any difference this makes.

* The default setting for the GroupEXP bonus was a static 100% person. My modifier simply replaces that, so you can't do a sliding bonus with it. It would be fairly straightforward to setup the sliding bonus and then apply my modifier to it so 2/6/10... could be 4/12/20 or 1/3/5.

* AAEXP is applied at the last minute so it will compound any other EXP bonuses.


Finally, there looked to be a couple of logic bugs in the Client:Death method in attack.cpp:844

The result of the initial '>' operation is being cast to a int32. I assume that the intention was to cast the number being compared to 0, so I updated the line to do this.

A few lines below when calculating a bonus EXP loss for guildwar servers, the same thing occurs. In addtion, there is a discrepency between the loss of EXP being tested and the loss being applied. I didn't update this value, but it seems likely that it should be.

Diff files would be easier to post, rather than cut/pastes of diff output. They would also be easier to apply to the code. Looks good though!

when do you merge this to the cvs trumpcard ? ^^;

When I can get it merged in...

Not to totaly rain on the parade but, shouldn't some of this stuff be class dependant also =)

NO!







:twisted:
:lol:

There aren't class modifiers anymore. :p

For anyone that hasn't heard, there are group bonus changes on test and will be going live on june 11th - these are substantial exp bonus changes, not sure if folks want to add them into the emu, but they range from 20-80% now, I'm not sure on the exact numbers, but those are for a 2 to 5 person group - the 6th person of the group is basically a free person, they don't detract any from the exp.

So each person in the group would get exp in a full group like it was a 5 person group.

Exp modifiers
 

As pointed out, there's no class modifyier for exp anymore.. however, there is race modifiers. If I recall correctly, Iksars got a 20% racial experience penalty, to make up for their increased regen/innate AC bonus..

Trolls I believe have that same penalty. I may be able to find a list of racial experience penalties.