EQEmulator Forums - Fix for period (.) screwing up Identifiers ($name, etc)

Yes, you could say that I'm on a bug hunt today. My goal, to kill all those little nitpicky bugs in the quest system that aggrevate me. :evil:

I'm a bit scared of this fix because of how simple it is. I can't find anything that it breaks, but perhaps some one else should eye this one closely. :?

The Problem:
When creating .qst files, putting a period (.) after an identifier will cause the quest to print NULL rather than the value of the identifier. For example this script will say NULL rather than your $name:

Quote:

EVENT_SAY {
if($1- =~ "Hail"){
SAY("Well met $name. I am Arianna Trueblade. Warlord of the Steel Warriors. I am personally in charge of all the training that our young warriors receive. I take pride in knowing that my teaching can help make the foundation of a Freeport Champion. If you are a [warrior] then we might just have something to talk about.")
}

The Fix:

Change line 1 of basic_functions.h from:

Code:

const char *notin = "() ,=!&|<>\"";

to:

Code:

const char *notin = "?.() ,=!&|<>\"";

Notice the period (.) at the beginning of the definition of notin.

Regards,

Krich