EQEmulator Forums - Melee's won't crit

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)

- Archive::Bugs (https://www.eqemulator.org/forums/forumdisplay.php?f=622)

- - Melee's won't crit > 10% health (https://www.eqemulator.org/forums/showthread.php?t=7814)

Melee's won't crit > 10% health

Many people on my system were complaining that they would not crit until the mob was less than 10% health. The bug was due to some brace funkiness in the code. Here's the fix:

attack.cpp, ~line 496

Code:

bool Client::Attack(Mob* other, int Hand, bool bRiposte)

...

line 496 currently:

else

        {//Message(0,"Wtf? You can\'t have more than 3 points in finishing blow");}

}

        

should be:

//else

        //{//Message(0,"Wtf? You can\'t have more than 3 points in finishing blow");}

}

attack.cpp ~line 545

Code:

        

bool Client::Attack(Mob* other, int Hand, bool bRiposte)

...

line 545 currently:

        other->Damage(this, damage, 0xffff, attack_skill);

        }



should be:

        other->Damage(this, damage, 0xffff, attack_skill);

        //}

On a side note:

Rangers get a whole truckload of crit hits (~75% shots of a lvl 65 uberly equipped ranger are crit bow hits) with bows and every other monk flying kick is a thunderous kick (TK is originally a disc you have to activate with a reuse of about 2 min or so at lvl 60).

I have had several crit hits with my warrior when I used the Emu 4.3 files, so it seems propable that an error slipped in during the changes made since then.

Corrected it in CVS.
Thanks Merth!