View Single Post
  #10  
Old 09-15-2008, 11:36 PM
James76
Sarnak
 
Join Date: Sep 2008
Location: Canada
Posts: 53
Default

I executed a

Code:
 UPDATE npc_types SET ATK=level*100, Accuracy=level*150
and it seems to be much more true to the game. Some mobs like Bertoxxulous still seem easy but at least they are hitting more often.. And the game isn't nearly so soloable anymore. Finally they can hit a naked me. And if I were dodging or whatever, it would say that in combat. It wouldn't say MISS MISS MISS MISS MISS MISS MISS....

As for the combat code, I looked through it to find an easy solution for the riposte problem (ripostes should happen on the attack, not on the hit) and I noticed reused variables, some genius thought it was smart to use the damage variable as a way to control combat, by setting it to specific values to indicate no hit, or a riposte, etc. This is the mark of the amateur developer. Also the redundancy between Client combat and Mob combat, considering inheritance should simplify things (Client inherits from Mob). Maybe they had a problem finding a way to call the parents method.. the easiet way is, for example from within Client::AvoidDamage() is to outright call Mob::AvoidDamage() and then anything specific to the Client can be handled. Or call it at the end. If its written in a way that prevents that from working, then it isn't following OOP rules and is poorly written.
Reply With Quote