I was able to get your monk H2H code in, but I haven't been able to get any of your other stuff tested yet. Part of the problem is that I am making some adjustments to how ProcChance and chancetohit work for certain things. So, some of your submission overlaps with what I am working on. Though, it looks like your stuff for ProcChance is just for formatting it correctly and not actually effecting the calculation equations. But, I like to do 1 thing at a time to reduce possible issues.
I am still trying to figure out the best way to get this stuff chanced in the source. Unless all of the code that was missing on the diff was already added to the SVN, It looks like even the diff that erde posted still doesn't have alot of the code that James76 posted. It is a definite starting place, though.
I hate to ask it, but;
James76, if you get a chance, is there anyway you could download the latest SVN and add in your changes to it and post a diff for them? You should be able to use something like examdiff or whatever, but I imagine with your coding experience, you probably know very well about how to do a diff, lol :P
Unless one of the other people with SVN access wants to add in what you have already submitted, then they can probably save you from having to do that diff. But, if it is going to be me adding it, I will need that diff or it will take me too much time to be worth it. I have a house, wife, kid, 2 forums to handle, a pretty popular emu server, and of course my own code changes and content to work on, so time is important to me. Not that I am any busier than most of the dev/mod team, because I know we all have stuff to keep us busy lol.
If anyone else from the team wants to try to get these added, feel free! It will stop any further time from being used up on this code change. Hopefully once we get this in, any further updates from James76 will move much quicker and smoother. Proper submission process will help that alot.
|