The list of what needs to be fixed in SoF is growing smaller daily
Last night, I got the NPC/PC trading bug fixed from when the window is closed as well as the tradeskill container bug when the window is closed. Live sends 2 new opcodes when those windows are closed and Titanium doesn't send them. I had to add 2 new opcodes for this to work. I should probably have this updated on the SVN later tonight.
I also got food consumption working and right click items are almost working. There are some new opcodes being used on Live for when an item is right clicked to be used. I haven't figured out exactly what is being sent in all cases, but in most cases, the client is just sending the slot that the item is in and then the server replies with that same slot. It also sends the entity ID of the client's current target. I assume this is some kind of verification that the item exists or something. I added 2 new opcodes for this as well and some handling for it. That got food/drink consumption working, but item right click effects still aren't actually casting their effects yet. It did stop the client from being bugged when trying to use right click effects though. From Live, it seems that these new item verification packets actually trigger the server to cast the effect. In Titanium, right clicking an item is just like casting a spell. The client sends the castspell packet and the server handles it from that point. Since it seems like SoF uses the new way from Live, it sounds like we will have to set the item verification (that is what I am calling it for now anyway) handling to cast the spells. I don't think that should be too hard, but I am open to any code suggestions
I also think there may need to be something done to stop right clickable items with recast delays from showing up as grey. I am sure there is either some new opcode that is supposed to tell the item how long the recast countdown is, or the recast delay countdown may be something that goes into one of the unknowns in the item serialization (this is my guess).
The item verification packets seem to be pretty straight forward in most cases. The odd thing is that certain items send "23 fa ff ff" when clicked instead of sending the slot id. I'm not quite sure what that is supposed to be, but it doesn't seem to be anything to do with the slot. I saw that same thing from one of my live packet collects and also on my test server from clicking an item with charges. It will probably take more investigation before I can get clickies all working properly, but at least it is getting closer. I may put the beginning work of these new opcodes and opcode handling on the SVN tonight as well.
Other than AAs, which I think need new AA tables just for SoF and coding to handle that, I think grouping is really the last major thing that needs to be fixed in SoF to have it almost as fully functional as Titanium is. I imagine raids will also need work too, but groups need to be working before we can get to working on raids. Either way, it is almost all done!