Yeah, Shendare had already messaged me about this:
Quote:
|
Originally Posted by Shendare
I don't know the best way to bring this up or to whose attention I should bring it, but I updated to the latest SVN (Rev52  and ran the SQL patch 524, but there were a number of lines with unescaped single quotes that errored out.
Specifically, the following (I escaped the offending single quotes and re-ran the commands):
UPDATE `rule_values` SET notes = 'item\'s hunger restored = this value * item\'s food level:100 = normal:50 = people eat 2x as fast:200 = people eat 2x as slow' WHERE rule_name = 'Character:ConsumptionMultiplier';
UPDATE `rule_values` SET notes = 'ms time until a player corpse is moved to a zone\'s graveyard:if one is specified for the zone' WHERE rule_name = 'Zone: GraveyardTimeMS';
UPDATE `rule_values` SET notes = 'wiz\'s crit chance:on top of BaseCritChance' WHERE rule_name = 'Spells:WizCritChance';
UPDATE `rule_values` SET notes = 'The bonus base crit chance you get when you\'re berserk' WHERE rule_name = 'Combat:BerserkBaseCritChance';
UPDATE `rule_values` SET notes = 'hit will fall off sharply if we\'re outside the minor and moderate range' WHERE rule_name = 'Combat:HitFalloffMajor';
UPDATE `rule_values` SET notes = 'Seconds between checks for failed tasks. Also used by the \'Touch\' activity' WHERE rule_name = 'TaskSystem:PeriodicCheckTimer';
Just thought I should bring it up to somebody's attention.
- Shendare |
There were so many rules to add with descriptions that I didn't read through all of them. Once these errors were mentioned, I figured I would just update that file with the corrections on my next SVN update. Re-running the SQL again won't hurt anything, so I don't think it is a big deal. I mostly just wanted to get something started for this. I don't really know if the SVN is the best way to implement optional table changes like this, but I did think it could be useful. At some point, it would be nice to get all of the notes for all rules filled out and then in the future, all new rule_values would include notes when they are added to the SVN. I think this should help considering the large number of rules that are in the table already and still continue to grow. I was also thinking about possibly adding in another field just to store the default value, so if people are playing with settings, they can easily reference the default value and set it back without having to look at ruletypes.h. Though, the default value could just be added to the notes field, which I am sure would suffice over having to add a whole new field that is essentially a second notes field.