Cool, the haste fix looks good now. I don't really know a ton about new pet stuff on live, and didn't look into your code enough to really tell if charmed pets would be affected or not. I didn't think it would be an issue, but that was the only possibility of an exploit I could think of from your changes. Sounds like it should be just fine. My concern was if people gave a charmed pet an item with charges and then broke charm and killed it, the item might have full charges again. Definitely sounds like that is not the case, which is good.
And yeah, the main reason I don't want to add this myself is because I am not the most knowledgeable about how pets should work. I also am always cautious when messing with the size of the player profile or extended profile. It looks like the SQL you submitted should keep there from being any issues, but those blobs can definitely cause major headaches if something goes wrong. Also, I think you are right that KLS is planning to do work on this for her Spells branch, so it may be best to see what she gets done and go from there.
|