DoT critical chance actually needs to be a negative number turned positive... this is never done in TryDoTCritical, and the only spell that I can see using it (I only skimmed over the spellfile) was rising terror. It's a negative number there.
Also, I had to revert the melee critical chance stuff in my local copy otherwise melee were critting every hit if they had a critical.
For some reason heals were doing nothing, had to revert the healrate stuff as well in my local copy.
Other than that looks good. Haven't looked at the rest. Definitely wouldn't try it on a server until the issues get worked out though.
|