I went ahead and commited this code, however I ended up making quite a few changes to the way bonuses were calculated so as to keep bots in line with whats available for clients atm. I can understand wanting to future proof the system by including all AAs up to Underfoot but it seems unfair until clients have access to those as well. In any case, its easy to add them back in once they are supported for clients. Also Slay undead and Chaotic Stab should now function correctly for bots.
Ideally I think a rewrite of bonus code for bots would be ideal so that it would pull bonuses from the owners AAs. This would mean however, a client who is a cleric would have bots that may not have access to certain AAs(for example melee AAs) and their bots would not benefit from them. I think it would add diversity to the bot system(a warrior client would have stronger melee bots than a cleric client bot's) but I'm not about to change the status quo so drastically, but something to ponder.
|