Melee crits not filtering would likely be my fault I've been fixing various other filters that were not working, and did not think i touched that one but i guess i did. I'll go poke at the code and see what I did. I made a lot of message changes in rev 2011 and 2012.
edit: hmm i did add in some changes to use string id's, but it is still a MT_CritMelee.
edit 2: Here is the change. I do not know why it would cause it not to filter unless there is a problem with MessageClose_StringID or something, but I used the same code when I changed pet flurry and enrage and those work.
Code:
===================================================================
--- C:/SVN Files/eqemu/trunk/EQEmuServer/zone/attack.cpp (revision 2011)
+++ C:/SVN Files/eqemu/trunk/EQEmuServer/zone/attack.cpp (revision 2012)
@@ -3866,7 +3866,7 @@
if (MakeRandomInt(0, 99) < critChance) {
critMod += GetCritDmgMob(skill) * 2; // To account for base crit mod being 200 not 100
damage = (damage * critMod) / 100;
- entity_list.MessageClose(this, false, 200, MT_CritMelee, "%s scores a critical hit!(%d)", GetCleanName(), damage);
+ entity_list.MessageClose_StringID(this, false, 200, MT_CritMelee, CRITICAL_HIT, GetCleanName(), itoa(damage));
}
}
}