Thanks for the response Uleat.
I don't think the ScaleItem function actually affects item stat scaling for when the character level is below the recommended level. The ScaleItem function looks to me like it only affects evolving items, and here's why...
The function is only ever called if the m_scaling value of the item instance is true. The m_scaling value is only ever set to true in the Initialize function (at least, there is no other occasion that it is set to true in my current version of the source code, but I haven't updated since 01/23/2014), and then only if the CharmFileID for the item is non-zero. In the current peq database there are exceptionally few items that have a non-zero charmfileid (or at least the 01/24/2014 dump that I'm currently using has exceptionally few). Additionally, the ScaleItem function itself doesn't check against the character level for the MOB that has the item equipped, nor against the reclevel for the item instance. Instead, the function checks against the *item's* accumulated EXP. As far as I know, only evolving items ever accumulate EXP.
Also, the items that I've used and noticed discrepancies with do not have non-zero charmfileid values, so they wouldn't be scaling from the ScaleItem function anyway.
Thanks for the suggestion, but I think the issue has to be somewhere else in the code. Also, I've ignored the apparent discrepancies and played normally a bit anyway, and it seems as though the HP discrepancy diminishes as the character levels up, but that Mana and Endurance discrepancies appear and then increase as the character levels up. I only just started paying attention to this last night, so I'm not positive that is actually happening. I'm going to do some deliberate testing for this and see if I can confirm the trend.
Also, I was poking around the code in a few other places, and I noticed that item stat scaling does not occur for bots based on bot level being below the reclevel for the equipped item. Is there a specific reason for this? Or was it simply not addressed previously? It seems to me that bots should *not* get full, unscaled stats from items if they're below the reclevel for the item.
Anyway, I'll keep poking around and see if I can figure anything out for this.
Thanks,
Drake Phoneix
|