EQEmulator Forums - View Single Post - Mem-leak in Client::QuestTroupe()

Deawin · #1 08-02-2003, 05:06 AM

Around line 2120 in client.cpp:

Code:

Message(13,"Attempting to delete petition number: %i",atoi(sep->argplus[1]));
			if (database.RunQuery(query, MakeAnyLenString(&amp;query, "DELETE from petitions where petid=%i",atoi(sep->argplus[1])), errbuf, &amp;result)) {
				safe_delete_array(query);
				LogFile->write(EQEMuLog::Normal,"Delete petition request from %s, petition number:", GetName(), atoi(sep->argplus[1]) );
			}
			//mysql_free_result(result); // If uncommented crashes zone. :/

If RunQuery() succeedes, result is never freed. I just moved the commented mysql_free_result below the if {} block into it.
Here is the corrected code piece:

Code:

Message(13,"Attempting to delete petition number: %i",atoi(sep->argplus[1]));
			if (database.RunQuery(query, MakeAnyLenString(&amp;query, "DELETE from petitions where petid=%i",atoi(sep->argplus[1])), errbuf, &amp;result)) {
				safe_delete_array(query);
				mysql_free_result(result);
				LogFile->write(EQEMuLog::Normal,"Delete petition request from %s, petition number:", GetName(), atoi(sep->argplus[1]) );
			}

Regards,
Markus