|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Development::Development Forum for development topics and for those interested in EQEMu development. (Not a support forum) |
09-21-2008, 02:31 PM
|
Developer
|
|
Join Date: Feb 2004
Location: UK
Posts: 1,540
|
|
/who all friend
Discussion: http://eqemulator.net/forums/showthread.php?t=26300
This patch is to enable /who all friend.
http://www.rama.demon.co.uk/friends.patch
There is only so much testing I can do with two toons on a private server, so let me know if something doesn't work right.
The 6.2 opcode is already in patch_6.2.conf. The opcode for patch_Titanium.conf is:
Code:
OP_FriendsWho=0x48fe
You will need to recompile world as well as zone.
|
09-21-2008, 05:56 PM
|
|
Developer
|
|
Join Date: Aug 2006
Location: USA
Posts: 5,946
|
|
How did I not see this one?! Nice work yet again! Stickying this!
|
09-22-2008, 12:20 AM
|
Developer
|
|
Join Date: Mar 2007
Location: Ohio
Posts: 648
|
|
Derision, once again you've saved me from having to learn assembly I think this is probably THE BIGGEST thing I've missed from Live, especially since I have started playing with others regularly on Emu servers
|
09-22-2008, 05:11 AM
|
Developer
|
|
Join Date: Feb 2004
Location: UK
Posts: 1,540
|
|
Quote:
Originally Posted by AndMetal
you've saved me from having to learn assembly
|
This is one of those Client->Server opcodes that didn't require any disassembly, just had to type /who all friend and look in the zone log output to see the 'Unknown Opcode' and that the packet contained a comma delimited list of friend names The response from the server to the client is the same opcode as used by /who all.
I'm going to rework this a bit to make it more efficient. I basically copied the /who all code, and it runs through the online client list twice, first to count how many friends are online so it can calculate how big the reply packet needs to be, and then again to actually build the reply packet.
Does anyone know if /who all friends should have an output limit of 20 players, the same as /who all ?
|
09-22-2008, 05:30 AM
|
|
Developer
|
|
Join Date: Aug 2006
Location: USA
Posts: 5,946
|
|
I think the friends list did used to be capped at 20 max at one time same as ignore, but I am pretty sure they removed that cap at some point before Titanium.
|
09-22-2008, 05:40 AM
|
Developer
|
|
Join Date: Feb 2004
Location: UK
Posts: 1,540
|
|
You can have up to 100 people on your friends list. What I was wondering was, if you had say 30 friends online, would /who all friend display all 30, or just the first 20. I guess it doesn't really matter how it works on live.
|
09-22-2008, 11:12 AM
|
Developer
|
|
Join Date: Mar 2007
Location: Ohio
Posts: 648
|
|
Quote:
Originally Posted by Derision
You can have up to 100 people on your friends list. What I was wondering was, if you had say 30 friends online, would /who all friend display all 30, or just the first 20. I guess it doesn't really matter how it works on live.
|
Last I knew, it would display all of them. If I remember correctly, the 20 limit was originally just the amount of friends you could have period, so that's all that would display. Then, it was upped (yay for the popular kids!), but I have no idea when that happened.
|
09-22-2008, 02:40 PM
|
Developer
|
|
Join Date: Feb 2004
Location: UK
Posts: 1,540
|
|
I've updated the patch in the original post with what should be a more efficient way of doing things. I'm not sure how caching in Firefox works, but when I clicked on the link after I updated the patch on my webhost, Firefox showed me the old version and I had to press F5 to get the new one.
The new version has todays date in the diff for clientlist.cpp, so you can check you aren't seeing an old cached copy:
Code:
diff -u --recursive /tmp/EQEmu-0.7.0-1129/world/clientlist.cpp ./world/clientlist.cpp
--- /tmp/EQEmu-0.7.0-1129/world/clientlist.cpp 2008-06-22 09:08:53.000000000 +0100
+++ ./world/clientlist.cpp 2008-09-22 19:04:13.000000000 +0100
|
09-24-2008, 11:05 PM
|
|
The PEQ Dude
|
|
Join Date: Apr 2003
Location: -
Posts: 1,988
|
|
This compiles fine under Linux, but under Windows I get:
.\clientlist.cpp(579) : error C3861: 'strtok_r': identifier not found
.\clientlist.cpp(592) : error C3861: 'strtok_r': identifier not found
The lines in question are:
char *Friend_ = strtok_r(FriendsWho->FriendsString, ",", &SavePointer);
and
Friend_ = strtok_r(NULL, ",", &SavePointer);
|
09-24-2008, 11:40 PM
|
Administrator
|
|
Join Date: Sep 2006
Posts: 1,348
|
|
There is no strtok_r for windows is the issue.
|
09-25-2008, 12:11 PM
|
Sarnak
|
|
Join Date: Aug 2007
Posts: 34
|
|
Quote:
Originally Posted by KLS
There is no strtok_r for windows is the issue.
|
and strtok_s is the windows equivalent. go go gadget precompiler!
|
09-25-2008, 12:57 PM
|
Developer
|
|
Join Date: Feb 2004
Location: UK
Posts: 1,540
|
|
I rewrote it without using strtok and did a test compile on Windows this time. Patch in the first post has been updated.
|
Posting Rules
|
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
|
|
|
All times are GMT -4. The time now is 02:45 AM.
|
|
|
|
|
|
|
|
|
|
|
|
|