1049 zone compile issues

[cubber]

I am trying to compile the 1049 source on gentoo and am running into errors when it goes to make zone. The 1044 source compiles fine and is running on the server currently.

Here is what happens when I run make from the zone folder:

make
gcc -c -Wall -Wuninitialized -Wwrite-strings -Wcast-qual -Wno-deprecated -Wcomment -Wcast-align -O2 -g -march=athlon-tbird -pthread -pipe -D_GNU_SOURCE -DINVERSEXY -DFX -DZONE -DEQDEBUG=5 -DCATCH_CRASH -DNO_PIDLOG -DSHAREMEM -DSPELL_EFFECT_SPAM -DFIELD_ITEMS -DCOMBINED -DAPP_OPCODE_SIZE=2 -Di386 -DEMBPERL -DEMBPERL_PLUGIN -DHAS_UNION_SEMUN -I/usr/include/mysql `perl -MExtUtils::Embed -e ccopts` spell_effects.cpp -o spell_effects.o
cc1plus: warning: command line option "-Wdeclaration-after-statement" is valid for C/ObjC but not for C++
spell_effects.cpp: In member function 'bool Mob::SpellEffect(Mob*, int16, float)':
spell_effects.cpp:208: warning: comparison between signed and unsigned integer expressions
spell_effects.cpp:588: warning: converting to 'int' from 'float'
spell_effects.cpp:602: warning: converting to 'sint32' from 'float'
spell_effects.cpp:646: warning: comparison between signed and unsigned integer expressions
spell_effects.cpp:670: warning: comparison between signed and unsigned integer expressions
spell_effects.cpp:776: error: expected `)' before 'spell'
spell_effects.cpp:776: warning: too few arguments for format
spell_effects.cpp:776: warning: too few arguments for format
spell_effects.cpp:944: warning: passing 'const float' for argument 2 to 'void Mob::SendAppearancePacket(int32, int32, bool, bool, Client*)'
spell_effects.cpp:1151: warning: converting to 'sint32' from 'float'
spell_effects.cpp:1466: warning: comparison between signed and unsigned integer expressions
spell_effects.cpp:1497: warning: comparison between signed and unsigned integer expressions
spell_effects.cpp:1531: warning: comparison between signed and unsigned integer expressions
spell_effects.cpp: In member function 'void Mob::BuffProcess()':
spell_effects.cpp:2348: warning: comparison between signed and unsigned integer expressions
spell_effects.cpp: In member function 'void Mob::BuffFadeBySlot(int, bool)':
spell_effects.cpp:2499: warning: comparison between signed and unsigned integer expressions
spell_effects.cpp: In member function 'sint16 Client::GetFocusEffect(focusType, int16)':
spell_effects.cpp:2908: warning: comparison is always true due to limited range of data type
spell_effects.cpp:2925: warning: comparison between signed and unsigned integer expressions
make: *** [spell_effects.o] Error 1


Thanks

[Derision]

John Adams posted a solution to this:

http://www.eqemulator.net/forums/showthread.php?t=23761&highlight=expected

Just involves adding a comma to line 776 in zone/spell_effects.cpp

[cubber]

Thanks that seemed to correct the issue.

[gernblan]

You can also just delete line 776 entirely. It's just a debug line KLS left in and isn't really used for anything else.

[cubber]

Seems to be the same in the 1050 sources.

[WildcardX]

This has been corrected in build 1051.