looting PVPItem and PVPReward is set to 3

paaco · #1 10-14-2008, 03:00 AM

Just started testing it a little, the zone crash seems to be fixed. The problem I have now is that when you loot a player every now and then it doesn't work. The players always drop the item, but every so often when you loot it, it never shows up in your inventory. You wont even notice that you don't get the item unless you pay attention. the server sends you no message or anything. You simply go through the motion of looting and then it never gets to inventory.

paaco · #2 10-14-2008, 06:18 AM

Just wanted to add that this is with Rev 92 on the SVN.

**Derision** · #3 10-14-2008, 02:07 PM

How frequently does this happen ? 1 in 10, 1 in 20 ? What item are you using as your PVPItem ? Are there any messages in the zone log when it happens ?

paaco · #4 10-14-2008, 02:37 PM

It happens quite frequently. 50/50 probably. You get no message in game of an error. It actually gives the "You have looted a PvP Token" message. It actually shows you looting. You right click, item disappears from the persons loot, it just never makes it to your inventory.
-The item number for the item I am using is 1041
-It is cutsom made, not Lore. ( Believe me I checked a lot ) Even have 11 of them I summoned in my inventory

The log that pops up when I loot someone is really weird. It doesn't seem like it should be connected in any way. When you kill someone, as soon as you loot them. This pops up in the logs.
[10.14. - 14:29:16] [CLIENT__NET_ERR] Paacotestbot: Unhandled incoming opcode: [OpCode OP_WeaponEquip2 (0x63da) Size=8]
[10.14. - 14:29:16] [CLIENT__NET_ERR] Paacotestbot: Unhandled incoming opcode: [OpCode OP_WeaponEquip1 (0x6c5e) Size=12]

Paacotestbot is the char that I killed and looted. Not the char that I am looting on.

paaco · #5 10-14-2008, 02:45 PM

Scratch that
[10.14. - 14:29:16] [CLIENT__NET_ERR] Paacotestbot: Unhandled incoming opcode: [OpCode OP_WeaponEquip2 (0x63da) Size=8]
[10.14. - 14:29:16] [CLIENT__NET_ERR] Paacotestbot: Unhandled incoming opcode: [OpCode OP_WeaponEquip1 (0x6c5e) Size=12]

Actually pops up right after you kill a player, has nothing to do with looting. Still weird, Paacotestbot has a lantern and the 1hs that you start with. Which hasn't been changed :(

**trevius** · #6 10-14-2008, 05:53 PM

Those log entries come in anytime a character zones and they aren't related to the issue you are having. That is just the client sending an opcode saying it is re-equiping the primary and secondary items, and the opcode isn't handled by the source code, because I don't think we know what to use it for if anything.

**Derision** · #7 10-15-2008, 02:27 PM

Quote:

Originally Posted by paaco

It happens quite frequently. 50/50 probably.

I was unable to reproduce this. I set PVPReward to 1041 (Worthless coin) and set the loregroup to 0. Killed a character 11 times with #damage 10000 and each time I looted the item it went into my inventory correctly.

paaco · #8 10-30-2008, 09:36 AM

OK I found the bug today. Dunno how I never figured it out until today. Although I have no clue how to fix it in the code. Looting the item from players works fine unless the item is stackable. If the item is stackable. You get the first one, after that it says you loot, but it never makes it to inventory.

paaco · #9 10-31-2008, 02:02 PM

Trying a fix for this on my next reboot, if it works I'll post the change.

paaco · #10 11-01-2008, 05:02 AM

What I came up with did not fix this. I would really appreciate it if someone better at C++ looked at it and figured out why items that stack do not work. It's no rush, I can make my item non stackable, but I would really love to make it stackable again just for the convenience.

**Derision** · #11 11-01-2008, 09:51 AM

I've submitted a fix for this to the SVN.

paaco · #12 11-01-2008, 11:22 AM

Thank you Derision, tested and it works great. Keep up the good work bro