Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Bug Reports

Development::Bug Reports Post detailed bug reports and what you would like to see next in the emu here.

 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
  #1  
Old 01-14-2011, 12:36 AM
l0stmancd
Fire Beetle
 
Join Date: Apr 2005
Posts: 23
Default Swap Item: Invalid slot move from slot 2.9 billion to slot 2.9 billion

See image http://imgur.com/8GqoP.

Trevius added code a while back to (revision 1272 March 01, 2010 to /trunk/eqemuserver/zone/inventory.cpp) to fix an issue where SoF+ clients would spam a slot move 3billion to slot 3billion every 10 minutes like clockwork. Appears to be happening at slot 2.9 billion now. Observed by myself and another user while playing. Both of us were using SoD. We had not seen this defect before but it started happening in the last ~3-4 days. I reviewed the recent checkins and I do not see any reason for this to happen so I assume its just a client quirk.

Not posting this in the code submissions forum since I do not know enough about this area to know if there is a problem with this fix but it -seems- quick and easy to fix. Just moving it from a > 3billion check to > 1 billion check. Honestly, even a billion is pretty far out there and should never be hit in normal circumstances but want to keep in the same order of magnitude as prior submission.

Code:
Index: inventory.cpp
===================================================================
--- inventory.cpp	(revision 1806)
+++ inventory.cpp	(working copy)
@@ -798,7 +798,7 @@
 
 	if(!IsValidSlot(src_slot_check)){
 		// SoF+ sends a 3 billion+ to/from slot every 10 minutes. Don't warn for those.
-		if(src_slot_check < 3000000000)
+		if(src_slot_check < 1000000000)
 			Message(13, "Warning: Invalid slot move from slot %u to slot %u with %u charges!", src_slot_check, dst_slot_check, stack_count_check);
 		mlog(INVENTORY__SLOTS, "Invalid slot move from slot %u to slot %u with %u charges!", src_slot_check, dst_slot_check, stack_count_check);
 		return false;
@@ -806,7 +806,7 @@
 
 	if(!IsValidSlot(dst_slot_check)) {
 		// SoF+ sends a 3 billion+ to/from slot every 10 minutes. Don't warn for those.
-		if(src_slot_check < 3000000000)
+		if(src_slot_check < 1000000000)
 			Message(13, "Warning: Invalid slot move from slot %u to slot %u with %u charges!", src_slot_check, dst_slot_check, stack_count_check);
 		mlog(INVENTORY__SLOTS, "Invalid slot move from slot %u to slot %u with %u charges!", src_slot_check, dst_slot_check, stack_count_check);
 		return false;
Reply With Quote
 


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 01:28 AM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3