#NPCEdit loottable

[TheLieka]

There's a typo in the command.cpp source that prevents #npcedit loottable (loottable_id) from working.

Fix:
.\zone\command.cpp
void command_npcedit(Client *c, const Seperator *sep)
{
if (!c->GetTarget() || !c->GetTarget()->IsNPC())
{
c->Message(0, "Error: Must have NPC targeted");
return;
}
...

c->Message(0, "#npcedit Hpregen - Sets an NPCs hitpoint regen rate per tick");
c->Message(0, "#npcedit Manaregen - Sets an NPCs mana regen rate per tick");
c->Message(0, "#npcedit Loottable - Sets the lootable ID for an NPC "); //Lieka Edit: Correct typo "Loottable" rather than "Lootable"
c->Message(0, "#npcedit Merchantid - Sets the merchant ID for an NPC");

...
{
char errbuf[MYSQL_ERRMSG_SIZE];
char *query = 0;
c->Message(15,"NPCID %u now regens %i mana per tick",c->GetTarget()->CastToNPC()->GetNPCTypeID(),atoi(sep->arg[2]));
database.RunQuery(query, MakeAnyLenString(&query, "update npc_types set mana_regen_rate=%i where id=%i",atoi(sep->argplus[2]),c->GetTarget()->CastToNPC()->GetNPCTypeID()), errbuf);
c->LogSQL(query);
safe_delete_array(query);
}
//Start Lieka Edit: Fix Loottable Typo
else if ( strcasecmp( sep->arg[1], "loottable" ) == 0 )
{
char errbuf[MYSQL_ERRMSG_SIZE];
char *query = 0;
c->Message(15,"NPCID %u is now on loottable_id %i",c->GetTarget()->CastToNPC()->GetNPCTypeID(),atoi(sep->arg[2]));
database.RunQuery(query, MakeAnyLenString(&query, "update npc_types set loottable_id=%i where id=%i",atoi(sep->argplus[2]),c->GetTarget()->CastToNPC()->GetNPCTypeID()), errbuf);
c->LogSQL(query);
safe_delete_array(query);//End Lieka Edit
}
else if ( strcasecmp( sep->arg[1], "merchantid" ) == 0 )
{
char errbuf[MYSQL_ERRMSG_SIZE];
char *query = 0;
c->Message(15,"NPCID %u now is merchant_id %i",c->GetTarget()->CastToNPC()->GetNPCTypeID(),atoi(sep->arg[2]));

....

[gernblan]

This is the fixed code? Please, can you point out the typo and what was fixed?

[WildcardX]

I'll look at this in the coming days to validate the code.

[TheLieka]

This is the fixed code. The parts in red are where it was changed. I'll post the broken code tonight.

Dax

[WildcardX]

I have validated your code and understand that your fix here is largely correcting a type, changing "lootable" to "loottable". I will commit your proposed change to the server code base.

Thank you for your contribution.