PDA

View Full Version : Client buffer overflow - stacked food


AndMetal
02-26-2008, 10:23 PM
If you stack a food item w/ augments (#si 724 20 xxxxx xxxxx xxxxx xxxxx), it will cause a buffer overflow error on the EQ Client. I'm not sure if it happens with all items that are stacked on top of it, but I know it happened when I used a custom augment (with insane stats).

I'm not sure if it could be used to execute code on the client, but it's definitely not a good thing.

I imagine the simple solution would be to add a check in the #si/#summonitem commands (http://eqemulator.cvs.sourceforge.net/eqemulator/EQEmuCVS/Source/zone/command.cpp?view=markup#l_4841) for the item type to see if it is food/drink (types 14/15), and if so, ignore the augments altogether.

KLS
03-04-2008, 09:00 PM
This whole command is nothing but an endless string of problems with that augment junk. >< Ima rewrite it sooner or later.